Why was this function header changed? I think it was correct before.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

Looks like the description part should only be in the @param part.
sysConfigTreatmentParameters should be an output? Input is None.
Add @details for alarms

align comment

The Id name looks too long? What if we change Temperature to Temp?

Please list names of variables in inputs and outputs.
You can move any description in the brief section.

Please add a comment for this check and break the line in two lines.

Please add a comment about this condition check.

Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

Please rename this function to initTreatmentParameters

Even if you do not have an Output, please add the tag with None as the value.
Please fix in other functions as well.

Please indent the doxygen comments of all the functions, similar to existing functions.

origTreatmentParams should be an output?

Delete extra line

· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-1, +1)	| History	| Source	| Diff

]]> Mon, 11 May 2026 09:42:58 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4188-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4188-1 Raghu Kallala Closed LEAHI-TD-FIRMWARE-LDT-4188-1 ]]> Mon, 11 May 2026 09:07:14 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4188-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4188-1 Michael Garthwaite and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-4188-1 LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI ]]> Wed, 06 May 2026 17:55:08 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28970 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28970 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Same comment as duration confirmation. compare uf rate too.

Also check uf rate from confirmation message (request) is still the same as validated uf rate.
WARNING - uf rate will be a float and we shouldn't use == operator on floats.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

2 lines above/below banner

remove blank line.

use response.x for these.

use response.duration.

Already set this above.

I don't think we should change this.