It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

Details looks weird. Where is inputs and outputs like other function headers?

Now it's backward. You have to change the ENABLE to DISABLE too.

Add a blank line after banner.

Please restore before you merge to staging.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

Should we set this flag to FALSE at top of loop?

Should we just set this flag to FALSE at top of loop?

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

Update comment.

Is this eventually going to be d1Temp?

align the indent.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

I had this commented again to push to the develop branch. It is uncommented for my testing.

added TODO above

updated as suggested.

updated.

updated accordingly.

added TODO for all

makes sense. removed it.

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

restored

Why did we remove this? This is needed for BC Switch only condition.

· /firmware/App/Monitors/Level.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommDD.h	(-0, +16)	| History	| Source	| Diff

]]> Sun, 10 May 2026 23:30:14 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-3 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-3978-3 ]]>