It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

Details looks weird. Where is inputs and outputs like other function headers?

Now it's backward. You have to change the ENABLE to DISABLE too.

Add a blank line after banner.

Please restore before you merge to staging.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

align the indent.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

I had this commented again to push to the develop branch. It is uncommented for my testing.

added TODO above

updated as suggested.

updated.

updated accordingly.

added TODO for all

makes sense. removed it.

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

restored

Why did we remove this? This is needed for BC Switch only condition.

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Remove this flag.

Remove this code.

Remove this condition to apply the speed for BC switch only as well.