Remove the TODO comment.

align the comment.

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pressure etc.,

decays to threshold level (4 PSI).

remove all commented code.

Update comment. remove TODO if no more applicable.

FillWaterEndState?

Delete it.

Supply state (instead of drain). Updates Inputs and outputs across the file.

When the BC fill completed and allow opening D65 for Chamber F fill?

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

50ms?

Add comment to align with the rest of the implementation.

Add outputs as well.

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

right now pre and post are same. make a TODO to update post later

its mixing control interval

could you document th math behind the calculation also

What is 4 (or 2)? Should be #define or enum or const.

Same as above.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

it shouldn't be the default value

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

This should return POST conductivity.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

Init PI Controls missing here.