Fisheye on dd-firmware/firmware/App/Controllers/BalancingChamber.h

LEAHI-DD-FIRMWARE-LDT-4612-1: started by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Thu, 25 Jun 2026 16:20:58 -0700

Vendor - TEL - Sameer Poyil started review LEAHI-DD-FIRMWARE-LDT-4612-1

LEAHI-DD-FIRMWARE-LDT-4612-1: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Thu, 25 Jun 2026 16:11:34 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-4612-1

LEAHI-DD-FIRMWARE-LDT-4612-1: reviewers finished

Thu, 25 Jun 2026 15:04:08 -0700

Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4612-1

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "Space after if."

Vinayakam Mani — Wed, 24 Jun 2026 14:47:01 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Space after if.

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "Can we bring depressurize as well one of the st..."

Vinayakam Mani — Wed, 24 Jun 2026 14:44:07 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "remove empty space after d66pressure variable. ..."

Vinayakam Mani — Wed, 24 Jun 2026 14:40:27 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

remove empty space after d66pressure variable. or match the indent to previous statement.

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "Add a TODO comment (remove later): this should ..."

Vinayakam Mani — Wed, 24 Jun 2026 14:36:35 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Add a TODO comment (remove later): this should be handled in IO/FP module.

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "Update comment."

Vinayakam Mani — Wed, 24 Jun 2026 14:33:17 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Update comment.

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "Add comment."

Vinayakam Mani — Wed, 24 Jun 2026 14:32:25 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Add comment.

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "Depressurize?"

Vinayakam Mani — Wed, 24 Jun 2026 14:30:56 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Depressurize?

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "Fix the typo."

Vinayakam Mani — Wed, 24 Jun 2026 14:22:26 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Fix the typo.

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vendor - TEL - Sameer Poyil "moved to general task"

Vendor - TEL - Sameer Poyil — Wed, 24 Jun 2026 13:49:58 -0700

Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4612-1

moved to general task

LEAHI-DD-FIRMWARE-LDT-4246-1: closed by Raghu Kallala

Raghu Kallala — Wed, 24 Jun 2026 06:36:55 -0700

Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-4246-1

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "Can we move this exec at task level, independen..."

Vinayakam Mani — Mon, 22 Jun 2026 12:29:27 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Can we move this exec at task level, independent of Drybicart operations?

LEAHI-DD-FIRMWARE-LDT-4612-1: comment by Vinayakam Mani "Comment missing?"

Vinayakam Mani — Mon, 22 Jun 2026 12:27:07 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Comment missing?

LEAHI-DD-FIRMWARE-LDT-4612-1: started by Dara Navaei

Dara Navaei — Thu, 18 Jun 2026 04:02:22 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4612-1

LEAHI-DD-FIRMWARE-LDT-4011-2: comment by Vendor - TEL - Jashwant Gantyada "comments start's with uppercase?"

Vendor - TEL - Jashwant Gantyada — Mon, 08 Jun 2026 09:21:02 -0700

Vendor - TEL - Jashwant Gantyada commented on LEAHI-DD-FIRMWARE-LDT-4011-2

comments start's with uppercase?

LEAHI-DD-FIRMWARE-LDT-4011-2: comment by Vendor - TEL - Jashwant Gantyada "comment starts with capital letter?"

Vendor - TEL - Jashwant Gantyada — Mon, 08 Jun 2026 09:15:27 -0700

Vendor - TEL - Jashwant Gantyada commented on LEAHI-DD-FIRMWARE-LDT-4011-2

comment starts with capital letter?

LEAHI-DD-FIRMWARE-LDT-4011-2: comment by Vendor - TEL - Jashwant Gantyada "do we have to leave a blank line after this?"

Vendor - TEL - Jashwant Gantyada — Mon, 08 Jun 2026 09:14:49 -0700

Vendor - TEL - Jashwant Gantyada commented on LEAHI-DD-FIRMWARE-LDT-4011-2

do we have to leave a blank line after this?

LEAHI-DD-FIRMWARE-LDT-4011-2: started by Dara Navaei

Dara Navaei — Thu, 04 Jun 2026 15:03:09 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4011-2

dd-firmware (bugfix/LDT-4539-provide-event-on-service-state-): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 22 May 2026 11:17:37 -0700

Dara Navaei committed a6737c3 on branch LDT-3223-dialysate-flow-rate---dd---mode-6-5-2026, LDT-3272-software-update---dd-firmware and 19 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/BalancingChamber.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DryBiCart.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/RinsePump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/RinsePump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/DDCommon.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/BloodLeakDriver.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensors.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivityTeensy.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenDialysate.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenDialysate.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Monitors/Level.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Monitors/Temperature.c

(-2, +2)

| History

| Source

| Diff

… 4 more files in changeset.

LEAHI-DD-FIRMWARE-LDT-3963-1: closed by Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada — Fri, 22 May 2026 11:11:01 -0700

Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3963-1

LEAHI-DD-FIRMWARE-LDT-3963-1: reviewers finished

Fri, 22 May 2026 10:50:41 -0700

Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3963-1

LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Jashwant Gantyada "restored"

Vendor - TEL - Jashwant Gantyada — Thu, 21 May 2026 15:24:19 -0700

Vendor - TEL - Jashwant Gantyada replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3963-1

restored

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Not sure why Crucible is showing it this way. ..."

Sean Nash — Thu, 21 May 2026 15:23:57 -0700

Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3963-1

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Should be #ifndef"

Sean Nash — Sun, 17 May 2026 23:23:10 -0700

Sean Nash replied to Vendor - TEL - Jashwant Gantyada in LEAHI-DD-FIRMWARE-LDT-3963-1

Should be #ifndef

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Should be #ifndef I think."

Sean Nash — Thu, 21 May 2026 15:13:44 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Should be #ifndef I think.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Can we make these low priority and 999 rank?"

Sean Nash — Thu, 21 May 2026 15:06:40 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Can we make these low priority and 999 rank?

dd-firmware (bugfix/LDT-4539-provide-event-on-service-state-): LDT-3963 addressed code review comments and restored the fault mode transition

Vendor - TEL - Jashwant Gantyada — Thu, 21 May 2026 13:32:51 -0700

Vendor - TEL - Jashwant Gantyada committed c4e1d97 on branch LDT-3223-dialysate-flow-rate---dd---mode-6-5-2026, LDT-3272-software-update---dd-firmware and 20 more in dd-firmware

LDT-3963 addressed code review comments and restored the fault mode transition

· /firmware/App/Controllers/BalancingChamber.c	(-40, +19)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/DDCommon.h	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/BloodLeakDriver.c	(-3, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Temperature.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtDD.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommDD.c	(-2, +2)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "It is weird that we're responding so far from r..."

Sean Nash — Sun, 17 May 2026 23:33:51 -0700

Sean Nash replied to Vendor - TEL - Jashwant Gantyada in LEAHI-DD-FIRMWARE-LDT-3963-1

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.