right now pre and post are same. make a TODO to update post later

its mixing control interval

could you document th math behind the calculation also

What is 4 (or 2)? Should be #define or enum or const.

Same as above.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

it shouldn't be the default value

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

This should return POST conductivity.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

Init PI Controls missing here.

13734.87F

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

both acid and bicarb mix volume

Add MULTIPLIER at the end.

Initialize at init function.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Lets remove this.

Done.

Done.

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

Done.