Fisheye on dd-firmware/firmware/App/Services/FpgaDD.c https://devapps.diality.us/changelog/~br%3DLDT-4734-temp-comp-conductivity/dd-firmware/firmware/App/Services/FpgaDD.c Recent activity in "dd-firmware" under directory /firmware/App/Services/FpgaDD.c LEAHI-DD-FIRMWARE-LDT-4611-4: started by Dara Navaei Wed, 15 Jul 2026 15:03:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4611-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4611-4 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4611-4 ]]> LEAHI-DD-FIRMWARE-LDT-4733-1: closed by Michael Garthwaite Tue, 14 Jul 2026 14:58:45 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-4733-1 ]]> LEAHI-DD-FIRMWARE-LDT-4733-1: reviewers finished Thu, 09 Jul 2026 15:40:26 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4733-1 LEAHI-DD-FIRMWARE-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data ]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:22 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30396 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30396 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:14 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30395 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30395 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:10 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30394 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30394 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:06 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30393 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30393 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:02 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30392 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30392 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "this would be out of scope of the original tick..." Thu, 09 Jul 2026 10:12:51 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30391 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30391 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733

Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "Did you get a chance to test this alarm and unc..." Wed, 08 Jul 2026 13:45:29 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30382 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30382 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Did you get a chance to test this alarm and uncomment the code?

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "Remove empty space." Wed, 08 Jul 2026 13:44:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30381 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30381 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Remove empty space.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "ACToDC?" Wed, 08 Jul 2026 13:44:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30380 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30380 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

ACToDC?

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "Count datatype seems to be integer. Type case t..." Wed, 08 Jul 2026 13:41:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30379 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30379 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Sean Nash "Align comment. Clarify (at least in comments) ..." Wed, 08 Jul 2026 10:39:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30378 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30378 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Align comment.
Clarify (at least in comments) that these macros are for FPGA count conversions.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Sean Nash "Remove extra blank lines." Wed, 08 Jul 2026 10:38:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30377 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30377 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Remove extra blank lines.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: started by Dara Navaei Thu, 25 Jun 2026 08:47:52 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4733-1 ]]> LEAHI-DD-FIRMWARE-LDT-4246-1: closed by Raghu Kallala Wed, 24 Jun 2026 06:36:55 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-4246-1 ]]> LEAHI-DD-FIRMWARE-LDT-4001-1: closed by Michael Garthwaite Thu, 11 Jun 2026 14:24:17 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-4001-1 ]]> LEAHI-DD-FIRMWARE-LDT-4001-1: reviewers finished Thu, 11 Jun 2026 13:27:23 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4001-1 LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4: ]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 10:08:28 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29802 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29802 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Should we change msg ID from speed to rate?" Thu, 11 Jun 2026 10:00:00 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29801 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29801 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Should we change msg ID from speed to rate?

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:59:46 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29800 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "its a speed in rpm. updated function to convert..." Thu, 11 Jun 2026 09:59:23 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29799 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29799 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:58:50 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29798 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29798 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "this is a set speed in rpm" Thu, 11 Jun 2026 09:57:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29797 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29797 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

this is a set speed in rpm

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "this is speed in rpm" Thu, 11 Jun 2026 09:57:38 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29796 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29796 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

this is speed in rpm

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:57:26 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29795 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29795 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:57:07 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29794 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29794 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:57:04 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29793 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29793 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Change speed to rate." Thu, 11 Jun 2026 09:43:35 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29791 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29791 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Change speed to rate.

]]>