Fisheye on dd-firmware/firmware/App/Drivers/FluidPump.c

Fisheye on dd-firmware/firmware/App/Drivers/FluidPump.c https://devapps.diality.us/changelog/~br%3DLDT-5357-nvm-conductivity-setcal/dd-firmware/firmware/App/Drivers/FluidPump.c Recent activity in "dd-firmware" under directory /firmware/App/Drivers/FluidPump.c LEAHI-DD-FIRMWARE-LDT-3975-2: reviewers joined LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Deg... Thu, 06 Aug 2026 18:37:58 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3975-2 LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4: ]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Update header" Thu, 06 Aug 2026 18:36:02 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31114 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31114 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Update header

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Align indent." Thu, 06 Aug 2026 18:28:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31113 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31113 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Align indent.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Add Doxygen comments." Thu, 06 Aug 2026 18:27:54 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31112 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31112 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Add Doxygen comments.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Align indent" Thu, 06 Aug 2026 18:26:15 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31111 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31111 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Align indent

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "0.0F" Thu, 06 Aug 2026 18:25:05 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31110 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31110 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

0.0F

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "p40RPMCnts -> typecast to F32." Thu, 06 Aug 2026 18:23:00 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31109 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31109 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

p40RPMCnts -> typecast to F32.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "mention as 30.0F, its being used in float calcu..." Thu, 06 Aug 2026 18:20:44 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31108 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31108 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

mention as 30.0F, its being used in float calculations.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "p40RPMCnts variable defined as U16, but assigni..." Thu, 06 Aug 2026 18:17:14 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31107 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31107 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

p40RPMCnts variable defined as U16, but assigning U32 value.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Add TODO or revert back changes." Wed, 05 Aug 2026 18:22:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31075 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31075 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Add TODO or revert back changes.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Delete empty line" Wed, 05 Aug 2026 18:20:34 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31074 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31074 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Delete empty line

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Add the comment." Wed, 05 Aug 2026 18:16:29 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31073 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31073 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Add the comment.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Align the indent throughout." Wed, 05 Aug 2026 18:15:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31071 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31071 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Align the indent throughout.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Add comment." Wed, 05 Aug 2026 18:15:22 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31072 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31072 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Add comment.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Space before and after paranthesis." Wed, 05 Aug 2026 18:04:29 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31070 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31070 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Space before and after paranthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "If debug is complete, do you want to revert bac..." Wed, 05 Aug 2026 18:02:36 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31069 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31069 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

If debug is complete, do you want to revert back to actual values? if you still need it for some more time, please add TODO comment.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Update the comment." Wed, 05 Aug 2026 17:50:25 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31068 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31068 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Update the comment.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Aling the indentation of value field." Wed, 05 Aug 2026 17:41:25 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31067 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31067 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Aling the indentation of value field.

]]> LEAHI-DD-FIRMWARE-LDT-3975-2: comment by Vinayakam Mani "Align the indentation." Wed, 05 Aug 2026 17:37:06 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31066 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2/#c31066 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3975-2

Align the indentation.

]]> LEAHI-DD-FIRMWARE-LDT-4873-2: started by Dara Navaei Mon, 03 Aug 2026 11:05:10 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-2 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4873-2 ]]> LEAHI-DD-FIRMWARE-LDT-5102-1: started by Dara Navaei Wed, 29 Jul 2026 04:02:19 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5102-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5102-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-5102-1 ]]> LEAHI-DD-FIRMWARE-LDT-4246-1: closed by Raghu Kallala Wed, 24 Jun 2026 06:36:55 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-4246-1 ]]> LEAHI-DD-FIRMWARE-LDT-3975-2: started by Dara Navaei Thu, 28 May 2026 13:47:03 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3975-2 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3975-2 ]]> LEAHI-DD-FIRMWARE-LDT-4246-1: started by Dara Navaei Wed, 06 May 2026 08:48:07 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4246-1 ]]> LEAHI-DD-FIRMWARE-LDT-3344-1: closed by Vendor - TEL - Jashwant Gantyada Tue, 24 Feb 2026 11:55:37 -0800 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3344-1 ]]> dd-firmware (LDT-872-dialysate-temperature-1): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 24 Feb 2026 10:38:34 -0800 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=046bc2b62cf942b7e846fa5bff698b94238edf24 https://devapps.diality.us/changelog/dd-firmware?cs=046bc2b62cf942b7e846fa5bff698b94238edf24 Dara Navaei committed 046bc2b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 84 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/RinsePump.c (-2, +2) | History | Source | Diff

· /firmware/App/Controllers/RinsePump.h (-2, +2) | History | Source | Diff

· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff

· /firmware/App/Drivers/FluidPump.c (-2, +2) | History | Source | Diff

· /firmware/App/Drivers/GPIO.c (-2, +2) | History | Source | Diff

· /firmware/App/Drivers/GPIO.h (-2, +2) | History | Source | Diff

· /firmware/App/Modes/FPModes/StateFlushConcentrate.c (-2, +2) | History | Source | Diff

· /firmware/App/Monitors/Level.c (-2, +2) | History | Source | Diff

· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff

· /firmware/App/Services/FpgaDD.c (-2, +2) | History | Source | Diff

· /firmware/App/Services/FpgaDD.h (-3, +3) | History | Source | Diff

· /firmware/App/Tasks/TaskPriority.c (-2, +2) | History | Source | Diff

]]> LEAHI-DD-FIRMWARE-LDT-3344-1: reviewers finished Tue, 24 Feb 2026 10:35:01 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Raghu Kallala , Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3344-1 LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates. ]]> LEAHI-DD-FIRMWARE-LDT-3344-1: started by Vendor - TEL - Jashwant Gantyada Mon, 23 Feb 2026 13:18:40 -0800 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Vendor - TEL - Jashwant Gantyada started review LEAHI-DD-FIRMWARE-LDT-3344-1 ]]> LEAHI-DD-FIRMWARE-LDT-3344-1: comment by Vendor - TEL - Sameer Poyil "This is total mess up . that is what I want it ..." Fri, 20 Feb 2026 14:19:23 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27522 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27522 Vendor - TEL - Sameer Poyil replied to Raghu Kallala in LEAHI-DD-FIRMWARE-LDT-3344-1

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

]]> LEAHI-DD-FIRMWARE-LDT-3344-1: comment by Vendor - TEL - Sameer Poyil "Removing all the review comments and created a ..." Fri, 20 Feb 2026 14:17:04 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27521 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27521 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3344-1

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

]]>