· /firmware/App/Controllers/Heaters.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.h	(-2, +2)	| History	| Source	| Diff

]]> Thu, 20 Aug 2026 13:32:34 -0700 Vendor - TEL - Suresh Dharnala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1 Vendor - TEL - Suresh Dharnala Closed LEAHI-DD-FIRMWARE-LDT-4049-1 ]]> Thu, 20 Aug 2026 11:50:49 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1 Michael Garthwaite and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4049-1 LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2: ]]> Wed, 19 Aug 2026 13:40:17 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c31510 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c31510 Michael Garthwaite commented on LEAHI-DD-FIRMWARE-LDT-4049-1

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

· /firmware/App/Modes/ModeStandby.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-0, +89)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.h	(-0, +3)	| History	| Source	| Diff

]]> Tue, 11 Aug 2026 10:18:15 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-3 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-5209-3 ]]> Fri, 07 Aug 2026 10:36:12 -0700 suresh https://devapps.diality.us/changelog/dd-firmware?cs=7665bfea357e3800ae5ac5f42658e31cde1d6a76 https://devapps.diality.us/changelog/dd-firmware?cs=7665bfea357e3800ae5ac5f42658e31cde1d6a76 suresh committed 7665bfe on branch LDT-4049-standby---fw-implementation---2, LDT-5470-post-treatment---fw-implementat, staging in dd-firmware Merge branch 'staging' into LDT-4049-standby---fw-implementation---2

· /firmware/App/Modes/ModeStandby.c

(-6, +6)

| History

| Source

| Diff

]]> Thu, 06 Aug 2026 09:20:24 -0700 Vendor - TEL - Suresh Dharnala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c31077 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c31077 Vendor - TEL - Suresh Dharnala replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4049-1

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

· /firmware/App/Modes/ModeStandby.c

(-5, +5)

| History

| Source

| Diff

]]> Thu, 30 Jul 2026 21:54:28 -0700 suresh https://devapps.diality.us/changelog/dd-firmware?cs=32b198b922f305a1838fe10e42d5dc83325f0180 https://devapps.diality.us/changelog/dd-firmware?cs=32b198b922f305a1838fe10e42d5dc83325f0180 suresh committed 32b198b on branch LDT-4049-standby---fw-implementation---2, LDT-5470-post-treatment---fw-implementat, staging in dd-firmware addressed review comments

· /firmware/App/Modes/FPModes/FPModeStandby.c	(-10, +20)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-7, +18)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-9, +2)	| History	| Source	| Diff

]]> Thu, 30 Jul 2026 11:23:44 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 Vendor - TEL - Arpita Srivastava Closed LEAHI-DD-FIRMWARE-LDT-3735-1 ]]> Thu, 30 Jul 2026 10:23:26 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3735-1 LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation ]]> Wed, 29 Jul 2026 17:37:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 Dara Navaei finished reviewing LEAHI-DD-FIRMWARE-LDT-3735-1 LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation ]]> Wed, 29 Jul 2026 11:06:17 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=ff0edadf0c6f161a0a092ddaf94d1940d64f7d5e https://devapps.diality.us/changelog/dd-firmware?cs=ff0edadf0c6f161a0a092ddaf94d1940d64f7d5e Dara Navaei committed ff0edad on branch LDT-3735-non-volatile-memory, LDT-3975-water-treatment-and-degassing-- and 22 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BoostPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DialysatePumps.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Voltages.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/NVMessagingDD.c	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Services/NVMessagingDD.h	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Services/NVRecordsDD.c	(-2, +5)	| History	| Source	| Diff
… 3 more files in changeset.

]]> Mon, 27 Jul 2026 14:22:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c30747 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4049-1/#c30747 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4049-1

you need to bring in the new set of valves here as well.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

Align the indent. Replace RO to FP.

Added but crucible is not showing this change. Please check bitbucket.

These variables are correctly initialized to the first enum in the list.

Not needed because the retry mechanism is going to be deleted in the next ticket.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

Not needed because the retry mechanism is going to be deleted in the next ticket.

· /firmware/App/Controllers/Heaters.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-0, +10)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-26, +25)	| History	| Source	| Diff

]]> Thu, 23 Jul 2026 11:22:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30669 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30669 Dara Navaei commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Same question as above: should we alarm if the retries failed?

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).