Fisheye on leahi-dialin/tests/test_ro.py

LEAHI-DIALIN-LDT-2655-1: reviewers finished

Mon, 30 Mar 2026 09:39:06 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..."

Michael Garthwaite — Mon, 16 Mar 2026 10:04:25 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

LEAHI-DIALIN-LDT-2655-1: reviewers joined LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei joined LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: reviewers removed from LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: comment by Sean Nash "Why do we have an "ro" and an "fp" folder? Is ..."

Sean Nash — Tue, 09 Dec 2025 14:26:46 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-2655-1

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

LEAHI-DIALIN-LDT-2655-1: started by Dara Navaei

Dara Navaei — Mon, 08 Dec 2025 08:15:35 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-566-2: closed by Michael Garthwaite

Michael Garthwaite — Tue, 05 Aug 2025 13:05:01 -0700

Michael Garthwaite Closed LEAHI-DIALIN-LDT-566-2

LEAHI-DIALIN-LDT-566-2: reviewers finished

Tue, 05 Aug 2025 12:50:55 -0700

Sean Nash and Vinayakam Mani finished reviewing LEAHI-DIALIN-LDT-566-2

LEAHI-DIALIN-LDT-566_Water Treatment And Degassing FP 2

LEAHI-DIALIN-LDT-566-2: comment by Sean Nash "Why so much white space?"

Sean Nash — Fri, 01 Aug 2025 15:47:05 -0700

Sean Nash commented on LEAHI-DIALIN-LDT-566-2

Why so much white space?

LEAHI-DIALIN-LDT-566-2: comment by Sean Nash "???"

Sean Nash — Fri, 01 Aug 2025 15:44:23 -0700

Sean Nash commented on LEAHI-DIALIN-LDT-566-2

???

LEAHI-DIALIN-LDT-566-2: comment by Sean Nash "Where is 0x5B?"

Sean Nash — Fri, 01 Aug 2025 15:40:11 -0700

Sean Nash commented on LEAHI-DIALIN-LDT-566-2

Where is 0x5B?

LEAHI-DIALIN-LDT-566-2: started by Dara Navaei

Dara Navaei — Mon, 23 Jun 2025 17:48:15 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-566-2

LEAHI-DIALIN-LEAH-261-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 23 Apr 2025 16:29:37 -0700

Michael Garthwaite Closed LEAHI-DIALIN-LEAH-261-1

LEAHI-DIALIN-LEAH-261-1: reviewers finished

Wed, 23 Apr 2025 16:02:54 -0700

Tiffany Mejia and Sean Nash finished reviewing LEAHI-DIALIN-LEAH-261-1

LEAHI-DIALIN-LEAH-261_FW RO Flow Sensor Driver

LEAHI-DIALIN-LEAH-261-1: started by Michael Garthwaite

Michael Garthwaite — Wed, 23 Apr 2025 15:16:55 -0700

Michael Garthwaite started review LEAHI-DIALIN-LEAH-261-1

LEAHI-DIALIN-LEAH-261-1: comment by Michael Garthwaite "fixed. Thanks!"

Michael Garthwaite — Wed, 23 Apr 2025 14:26:07 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-261-1

fixed. Thanks!

LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "Remove extra blank line."

Sean Nash — Mon, 24 Feb 2025 09:49:44 -0800

Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

Remove extra blank line.

LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "function header?"

Sean Nash — Mon, 24 Feb 2025 09:47:55 -0800

Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

function header?

LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "We should remove DG references throughout. If ..."

Sean Nash — Mon, 24 Feb 2025 09:44:39 -0800

Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

We should remove DG references throughout. If f/w doesn't call for some of these yet, lets just remove them for now.

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): WIP on develop...

Michael Garthwaite — Fri, 21 Feb 2025 08:23:54 -0800

Michael Garthwaite committed 0f08c28 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 85 more in leahi-dialin

WIP on develop

Renamed RO class and sub modules to use FP to be in line with sub system names

· /leahi_dialin/__init__.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/fp/__init__.py

(-0, +1)

| History

| Source

· /leahi_dialin/fp/filtration_purification.py

(-0, +250)

| History

| Source

· /leahi_dialin/fp/modules/__init__.py

(-0, +0)

| History

| Source

· /leahi_dialin/fp/modules/boost_pump.py

(-0, +256)

| History

| Source

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-0, +230)

| History

| Source

· /leahi_dialin/fp/modules/constants.py

(-0, +18)

| History

| Source

· /leahi_dialin/fp/modules/flow_sensors.py

(-0, +175)

| History

| Source

· /leahi_dialin/fp/modules/levels.py

(-0, +135)

| History

| Source

· /leahi_dialin/fp/modules/pressure_sensors.py

(-0, +220)

| History

| Source

· /leahi_dialin/fp/modules/valves.py

(-0, +294)

| History

| Source

· /leahi_dialin/protocols/CAN.py

(-10, +10)

| History

| Source

| Diff

· /leahi_dialin/ro/__init__.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/__init__.py

(-0, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/boost_pump.py

(-255, +0)

| History

| Source

| Diff

… 9 more files in changeset.

LEAHI-DIALIN-LEAH-261-1: started by Dara Navaei

Dara Navaei — Fri, 14 Feb 2025 09:26:45 -0800

Dara Navaei started review LEAHI-DIALIN-LEAH-261-1