Fisheye on td-firmware/firmware/App/Services/StateServices https://devapps.diality.us/changelog/~br%3Dbugfix%25402fLDT-4160-request-get-function-for-full-d/td-firmware/firmware/App/Services/StateServices Recent activity in "td-firmware" under directory /firmware/App/Services/StateServices LEAHI-TD-FIRMWARE-LDT-4013-2: reviewers finished Mon, 15 Jun 2026 14:47:43 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 Vendor - TEL - Jashwant Gantyada , Vendor - TEL - Arpita Srivastava and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-4013-2 LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4: ]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Thank you for the clarification!" Mon, 15 Jun 2026 11:36:28 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29916 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29916 Vendor - TEL - Arpita Srivastava replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4013-2

Thank you for the clarification!

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "break into two lines" Mon, 15 Jun 2026 11:33:03 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29915 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29915 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

break into two lines

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG" Mon, 15 Jun 2026 11:32:09 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29914 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29914 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Add newAlarmIndicateStop to output" Mon, 15 Jun 2026 11:27:41 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29913 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29913 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Add newAlarmIndicateStop to output

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Add newAlarmIndicateStop to input and output." Mon, 15 Jun 2026 11:21:36 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29912 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29912 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Add newAlarmIndicateStop to input and output.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Arpita, we don't want to use doxygen style comm..." Fri, 12 Jun 2026 23:04:10 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29898 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29898 Sean Nash replied to Vendor - TEL - Arpita Srivastava in LEAHI-TD-FIRMWARE-LDT-4013-2

Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vinayakam Mani "Bubble status, Low and high level level sensors..." Fri, 12 Jun 2026 17:40:28 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29896 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29896 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Bubble status, Low and high level level sensors.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vinayakam Mani "Input : Blood pump door status?" Fri, 12 Jun 2026 17:39:14 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29895 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29895 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Input : Blood pump door status?

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vinayakam Mani "To be restored?" Fri, 12 Jun 2026 17:27:34 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29894 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29894 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-2240-1

To be restored?

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vinayakam Mani "Are these being initialized in the init functio..." Fri, 12 Jun 2026 17:24:24 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29893 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29893 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Are these being initialized in the init function?

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vinayakam Mani "Need to resolve the merge issues?" Fri, 12 Jun 2026 17:16:04 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29892 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29892 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Need to resolve the merge issues?

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "pauseBolusResumeState is input" Fri, 12 Jun 2026 15:50:24 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29890 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29890 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

pauseBolusResumeState is input

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "add alarm" Fri, 12 Jun 2026 15:47:28 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29889 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29889 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

add alarm

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Replace // to ///< for line 56 to 60" Fri, 12 Jun 2026 15:45:41 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29888 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29888 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Replace // to ///< for line 56 to 60

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: reviewers added to LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implem... Fri, 12 Jun 2026 15:27:04 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 Sean Nash added Vendor - TEL - Jashwant Gantyada to LEAHI-TD-FIRMWARE-LDT-4013-2 LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4: ]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Use // comments for function prototypes." Fri, 12 Jun 2026 15:06:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29887 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29887 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Use // comments for function prototypes.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Either no comment or // comment for function pr..." Fri, 12 Jun 2026 15:06:17 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29886 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29886 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "These were fine (and preferred) as // because d..." Fri, 12 Jun 2026 15:04:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29885 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29885 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Should we be looking at tubing set type instead..." Fri, 12 Jun 2026 09:32:29 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29845 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29845 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Should we be looking at tubing set type instead of modality here?

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Can we not determine this now? Why TODO?" Fri, 12 Jun 2026 09:28:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29844 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29844 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Can we not determine this now? Why TODO?

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Shouldn't we be checking tubing set type instea..." Fri, 12 Jun 2026 09:27:41 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29843 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29843 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Shouldn't we be checking tubing set type instead of modality here?

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "verify given type is valid (< NUM_OF_TUBE_SET_T..." Fri, 12 Jun 2026 09:23:16 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29840 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29840 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Initialize to UNKNOWN type. Remove TODO." Fri, 12 Jun 2026 09:22:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29839 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29839 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Initialize to UNKNOWN type. Remove TODO.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as fi..." Fri, 12 Jun 2026 09:21:16 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29838 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29838 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Use /// when above, use ///< when to the right...." Fri, 12 Jun 2026 09:17:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29836 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29836 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Use /// when above, use ///< when to the right.
Also remove extra space before Tube

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Change // to ///<" Fri, 12 Jun 2026 09:17:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29837 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29837 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Change // to ///<

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: started by Dara Navaei Fri, 12 Jun 2026 04:02:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-4013-2 ]]> LEAHI-TD-FIRMWARE-LDT-4013-1: closed by Vendor - TEL - Praneeth Bunne Thu, 11 Jun 2026 22:29:14 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1 Vendor - TEL - Praneeth Bunne Closed LEAHI-TD-FIRMWARE-LDT-4013-1 ]]> td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 05 Jun 2026 10:29:11 -0700 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=9c833ef5623ce842267e284d958820ac0dc3a7fc https://devapps.diality.us/changelog/td-firmware?cs=9c833ef5623ce842267e284d958820ac0dc3a7fc Dara Navaei committed 9c833ef on branch LDT-2240-disposable-tube-set-self-test, LDT-3215-measured-venous-pressure-decreases and 12 more in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModePreTreat.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/StateTxBloodPrime.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/StateTxBloodPrime.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/StateTxDialysis.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/StateTxDialysis.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/StateTxPaused.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/StateTxPaused.h (-2, +2) | History | Source | Diff
· /firmware/App/Monitors/Pressures.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtTD.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/DDInterface.h (-2, +2) | History | Source | Diff
… 7 more files in changeset.
]]>