Can we move this exec at task level, independent of Drybicart operations?

Comment missing?

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-25, +19)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-4, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +2)	| History	| Source	| Diff
· /firmware/source/sys_main.c	(-0, +1)	| History	| Source	| Diff

]]> Thu, 18 Jun 2026 10:06:02 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=b6411a65e0c78fe8b296c047a1d6940c55fa64f5 https://devapps.diality.us/changelog/dd-firmware?cs=b6411a65e0c78fe8b296c047a1d6940c55fa64f5 Vendor - TEL - Sameer Poyil committed b6411a6 on branch LDT-4612-dialysate-composition-integ, develop in dd-firmware LDT-4409 fix for concentrate pump not running

· /firmware/App/Controllers/DryBiCart.c	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-1, +1)	| History	| Source	| Diff
· /firmware/source/sys_main.c	(-0, +1)	| History	| Source	| Diff

]]> Thu, 18 Jun 2026 04:02:22 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4612-1 ]]> Wed, 27 May 2026 16:24:39 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3272-1 ]]> Wed, 27 May 2026 16:22:27 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=b265dcfa9029a6db5ab4b6a966aae70103004781 https://devapps.diality.us/changelog/dd-firmware?cs=b265dcfa9029a6db5ab4b6a966aae70103004781 Dara Navaei committed b265dcf on branch develop in dd-firmware Resolved the conflicts from staging

· /firmware/source/sys_main.c

(-3, +0)

| History

| Source

| Diff

]]> Wed, 27 May 2026 16:20:41 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=dc451e960ab328d05a06137ffdc4d8b2b1601d55 https://devapps.diality.us/changelog/dd-firmware?cs=dc451e960ab328d05a06137ffdc4d8b2b1601d55 Dara Navaei committed dc451e9 on branch develop in dd-firmware Merged staging and resolved conflicts

· /firmware/App/Controllers/BalancingChamber.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-3, +42)	| History	| Source	| Diff
· /firmware/source/sys_main.c	(-0, +5)	| History	| Source	| Diff

]]> Wed, 27 May 2026 15:38:22 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3272-1 LEAHI-DD-FIRMWARE-LDT-3272_Software Update - DD ]]> Wed, 27 May 2026 14:15:45 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4002-1/#c29429 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4002-1/#c29429 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4002-1

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop similar to UF pump.
GenDialysate mode will have an HDF sub-state that signals this controller from Off to On and would also call separate controller for heater and separate (Switches) monitor for door sensors.

With all of that in mind, I think this unit should have a simpler name like SubPump.

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch state(s) (e.g. while in HDF state, we would expect the cap to be open and stowed and we would want to alarm if that was not the case).

Remove extra blank line.

· /firmware/App/Services/Messaging.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommDD.h	(-16, +0)	| History	| Source	| Diff
· /firmware/DD.dil	(-16, +16)	| History	| Source	| Diff
· /firmware/source/can.c	(-10, +10)	| History	| Source	| Diff

]]> Wed, 27 May 2026 14:31:35 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4002-1/#c29435 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4002-1/#c29435 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4002-1

Where is call to HDF controller?

Monitors should come before mode mgmt above.

What about HemoDiaFiltration.h?

What about initHDF?

Where is HemoDiaFiltration.h?

Why does this file name have pound signs pre/post?

This macro is already defined in Common.h.

Align all "=" or none of them.

DD HDF control data published should just be state and set rate. TD HDF data would have volume, etc...

This looks like pump control function. I think TD f/w should be doing this when setting Qsub before sending to DD f/w. Again, I think DD f/w should just be controlling pump to the Qsub rate given by TD f/w.
HDF volume should be calculated by TD f/w by integrating commanded Qsub over time.

Remove blank line.

Refactor so that only one return statement at end of function. This is in our coding standards.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

I think TD should be handling all of these rules before setting Qsub and sending to DD.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.