Fisheye on dialin/.gitignore https://devapps.diality.us/changelog/~br%3Ddevelop/dialin/.gitignore Recent activity in "dialin" under directory /.gitignore DIALIN-ACK-1: closed by Dara Navaei Thu, 19 Oct 2023 13:19:52 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-ACK-1 https://devapps.diality.us/cru/DIALIN-ACK-1 Dara Navaei Closed DIALIN-ACK-1 ]]> DIALIN-ACK-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 13:19:42 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-ACK-1/#c19201 https://devapps.diality.us/cru/DIALIN-ACK-1/#c19201 Dara Navaei replied to Behrouz NematiPour in DIALIN-ACK-1

RESOLVED

]]> DIALIN-ACK-1: started by Dara Navaei Thu, 19 Oct 2023 13:19:20 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-ACK-1 https://devapps.diality.us/cru/DIALIN-ACK-1 Dara Navaei started review DIALIN-ACK-1 ]]> DIALIN-DEN-16093-1: closed by Vinayakam Mani Fri, 01 Sep 2023 17:05:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/DIALIN-DEN-16093-1 https://devapps.diality.us/cru/DIALIN-DEN-16093-1 Vinayakam Mani Closed DIALIN-DEN-16093-1 ]]> DIALIN-DEN-16093-1: reviewers finished Wed, 23 Aug 2023 10:03:56 -0700 https://devapps.diality.us/cru/DIALIN-DEN-16093-1 https://devapps.diality.us/cru/DIALIN-DEN-16093-1 Michael Garthwaite finished reviewing DIALIN-DEN-16093-1 DIALIN-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment ]]> DIALIN-DEN-16093-1: comment by Michael Garthwaite "RESOLVED." Wed, 23 Aug 2023 10:03:39 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18694 https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18694 Michael Garthwaite replied to Vinayakam Mani in DIALIN-DEN-16093-1

RESOLVED.

]]> DIALIN-DEN-16093-1: comment by Michael Garthwaite "RESOLVED." Wed, 23 Aug 2023 10:03:31 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18692 https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18692 Michael Garthwaite replied to Vinayakam Mani in DIALIN-DEN-16093-1

RESOLVED.

]]> DIALIN-DEN-16093-1: reviewers finished Tue, 22 Aug 2023 14:29:36 -0700 https://devapps.diality.us/cru/DIALIN-DEN-16093-1 https://devapps.diality.us/cru/DIALIN-DEN-16093-1 Sean Nash finished reviewing DIALIN-DEN-16093-1 DIALIN-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment ]]> DIALIN-DEN-16093-1: comment by Vinayakam Mani "it looks to be auto generated by PyCharm and wa..." Tue, 22 Aug 2023 13:42:07 -0700 Vinayakam Mani https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18689 https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18689 Vinayakam Mani replied to Michael Garthwaite in DIALIN-DEN-16093-1

it looks to be auto generated by PyCharm and was committed earlier. Its removed now.

]]> DIALIN-DEN-16093-1: comment by Vinayakam Mani "Updated." Tue, 22 Aug 2023 13:40:00 -0700 Vinayakam Mani https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18688 https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18688 Vinayakam Mani replied to Michael Garthwaite in DIALIN-DEN-16093-1

Updated.

]]> dialin (DIAL-290-pressure_occlusion.py-dialin-documentation-not-updated-in-staging): DEN-16093-updated enum variable Tue, 22 Aug 2023 13:39:36 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dialin?cs=04e3493d28e5996dd57996923725af1051de7d31 https://devapps.diality.us/changelog/dialin?cs=04e3493d28e5996dd57996923725af1051de7d31 Vinayakam Mani committed 04e3493 on branch DEN-16093-alarm-97-conductivity-out-of-range-triggered-on-first-fill-of-treatment, DEN-16242-pressure-limit-request-fix and 82 more in dialin DEN-16093-updated enum variable

· /.gitignore (-1, +1) | History | Source | Diff
· /dialin/common/msg_ids.py (-1, +1) | History | Source | Diff
]]> DIALIN-DEN-16093-1: comment by Michael Garthwaite "Please change the naming of 0x83 to what you ha..." Tue, 22 Aug 2023 08:58:46 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18665 https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18665 Michael Garthwaite commented on DIALIN-DEN-16093-1

Please change the naming of 0x83 to what you have in your latest common branch

]]> DIALIN-DEN-16093-1: comment by Michael Garthwaite "Typical dialin projects don't have or generate ..." Tue, 22 Aug 2023 08:57:35 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18664 https://devapps.diality.us/cru/DIALIN-DEN-16093-1/#c18664 Michael Garthwaite commented on DIALIN-DEN-16093-1

Typical dialin projects don't have or generate a .metadata folder. How are you creating this and why does it need to be ignored?

]]> dialin (DIAL-290-pressure_occlusion.py-dialin-documentation-not-updated-in-staging): DEN-16093-addedDGparkConcentratePumpsandRemovedEnumsNolongerinUse Mon, 21 Aug 2023 13:43:10 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dialin?cs=92ab2f51edaf18c3a24e51e151bb6d390e7acf6e https://devapps.diality.us/changelog/dialin?cs=92ab2f51edaf18c3a24e51e151bb6d390e7acf6e Vinayakam Mani committed 92ab2f5 on branch DEN-16093-alarm-97-conductivity-out-of-range-triggered-on-first-fill-of-treatment, DEN-16242-pressure-limit-request-fix and 82 more in dialin DEN-16093-addedDGparkConcentratePumpsandRemovedEnumsNolongerinUse

· /.gitignore (-0, +1) | History | Source | Diff
· /dialin/common/msg_ids.py (-6, +6) | History | Source | Diff
· /dialin/ui/dg_simulator.py (-16, +0) | History | Source | Diff
· /dialin/ui/hd_simulator.py (-16, +0) | History | Source | Diff
]]> DIALIN-DEN-16093-1: started by Dara Navaei Fri, 18 Aug 2023 12:04:26 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-16093-1 https://devapps.diality.us/cru/DIALIN-DEN-16093-1 Dara Navaei started review DIALIN-DEN-16093-1 ]]> DIALIN-UCOMMITS-16: closed by Sean Nash Thu, 03 Aug 2023 13:19:58 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-UCOMMITS-16 https://devapps.diality.us/cru/DIALIN-UCOMMITS-16 Sean Nash Closed DIALIN-UCOMMITS-16 ]]> DIALIN-UCOMMITS-16: reviewers finished Thu, 03 Aug 2023 10:36:41 -0700 https://devapps.diality.us/cru/DIALIN-UCOMMITS-16 https://devapps.diality.us/cru/DIALIN-UCOMMITS-16 Dara Navaei finished reviewing DIALIN-UCOMMITS-16 DIALIN Staging Unreviewed Commits ]]> DIALIN-UCOMMITS-16: reviewers finished Wed, 02 Aug 2023 17:38:50 -0700 https://devapps.diality.us/cru/DIALIN-UCOMMITS-16 https://devapps.diality.us/cru/DIALIN-UCOMMITS-16 Sean Nash finished reviewing DIALIN-UCOMMITS-16 DIALIN Staging Unreviewed Commits ]]> DIALIN-UCOMMITS-16: started by Dara Navaei Mon, 08 May 2023 11:01:43 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-UCOMMITS-16 https://devapps.diality.us/cru/DIALIN-UCOMMITS-16 Dara Navaei started review DIALIN-UCOMMITS-16 ]]> DIALIN-DEN-9480-1: closed by Dara Navaei Thu, 11 Nov 2021 14:02:29 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-9480-1 https://devapps.diality.us/cru/DIALIN-DEN-9480-1 Dara Navaei Closed DIALIN-DEN-9480-1 ]]> DIALIN-DEN-9480-1: reviewers finished Thu, 11 Nov 2021 13:57:08 -0800 https://devapps.diality.us/cru/DIALIN-DEN-9480-1 https://devapps.diality.us/cru/DIALIN-DEN-9480-1 hnguyen  (deleted user) and Sean Nash finished reviewing DIALIN-DEN-9480-1 DIALIN-DEN-9480_DG_DEV Dialysate Temperature Control ]]> DIALIN-DEN-9480-1: comment by hnguyen "RESOLVED in CODE WALKTHROUGH" Thu, 11 Nov 2021 13:56:15 -0800 hnguyen https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11400 https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11400 hnguyen  (deleted user) replied to Dara Navaei in DIALIN-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

]]> DIALIN-DEN-9480-1: comment by Sean Nash "RESOLVED." Thu, 11 Nov 2021 13:54:09 -0800 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11399 https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11399 Sean Nash replied to Dara Navaei in DIALIN-DEN-9480-1

RESOLVED.

]]> DIALIN-DEN-9480-1: comment by Sean Nash "RESOLVED." Thu, 11 Nov 2021 13:53:55 -0800 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11398 https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11398 Sean Nash replied to Dara Navaei in DIALIN-DEN-9480-1

RESOLVED.

]]> DIALIN-DEN-9480-1: comment by Dara Navaei "This is considered as an optimization. I will i..." Thu, 11 Nov 2021 12:46:53 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11397 https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11397 Dara Navaei replied to Sean Nash in DIALIN-DEN-9480-1

This is considered as an optimization. I will implement it in DEN-11114.

]]> DIALIN-DEN-9480-1: comment by Dara Navaei "I remember there was a case that was not covere..." Tue, 09 Nov 2021 21:03:09 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11233 https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11233 Dara Navaei replied to Sean Nash in DIALIN-DEN-9480-1

I remember there was a case that was not covered so I made this a separate to make sure it always is executed.

]]> DIALIN-DEN-9480-1: comment by Dara Navaei "It is true we should be consistent. I added the..." Thu, 11 Nov 2021 11:14:45 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11396 https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11396 Dara Navaei replied to Sean Nash in DIALIN-DEN-9480-1

It is true we should be consistent. I added the NUM_OF_... at the end of the enum.

]]> DIALIN-DEN-9480-1: comment by Dara Navaei "Fixed the return." Thu, 11 Nov 2021 11:11:12 -0800 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11395 https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11395 Dara Navaei replied to hnguyen  (deleted user) in DIALIN-DEN-9480-1

Fixed the return.

]]> DIALIN-DEN-9480-1: comment by hnguyen "There are 2 returns in this function and why @r..." Thu, 11 Nov 2021 10:22:52 -0800 hnguyen https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11367 https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11367 hnguyen  (deleted user) commented on DIALIN-DEN-9480-1

There are 2 returns in this function and why @return: None here?

]]> DIALIN-DEN-9480-1: comment by Sean Nash "RESOLVED." Thu, 11 Nov 2021 09:47:36 -0800 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11366 https://devapps.diality.us/cru/DIALIN-DEN-9480-1/#c11366 Sean Nash replied to Dara Navaei in DIALIN-DEN-9480-1

RESOLVED.

]]>