Fisheye on leahi-dialin/leahi_dialin/dd/modules/drybicart.py

LEAHI-DIALIN-LDT-2004-5: reviewers finished

Wed, 18 Mar 2026 14:27:13 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-2004-5

LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD

LEAHI-DIALIN-LDT-2004-5: started by Dara Navaei

Dara Navaei — Mon, 16 Mar 2026 11:10:20 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-2004-5

LEAHI-DIALIN-LDT-3557-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 05 Mar 2026 10:46:36 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Thu, 05 Mar 2026 10:25:20 -0800

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Tue, 03 Mar 2026 16:58:49 -0800

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

LEAHI-DIALIN-LDT-3557-1: comment by Zoltan Miskolci "removed"

Zoltan Miskolci — Tue, 03 Mar 2026 15:28:18 -0800

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-3557-1

removed

LEAHI-DIALIN-LDT-3557-1: comment by Michael Garthwaite "Remove this extra line"

Michael Garthwaite — Tue, 03 Mar 2026 09:13:22 -0800

Michael Garthwaite commented on LEAHI-DIALIN-LDT-3557-1

Remove this extra line

leahi-dialin (feature/LDT-3800-enhancements-usability-requests): - Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TE...

Zoltan Miskolci — Wed, 25 Feb 2026 18:57:01 -0800

Zoltan Miskolci committed 20c821b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 20 more in leahi-dialin

- Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

· /leahi_dialin/common/__init__.py

(-3, +3)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs.py

(-49, +1)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs_proxy.py

(-0, +63)

| History

| Source

· /leahi_dialin/common/fp_defs.py

(-37, +1)

| History

| Source

| Diff

· /leahi_dialin/common/fp_defs_proxy.py

(-0, +51)

| History

| Source

· /leahi_dialin/common/td_defs.py

(-47, +1)

| History

| Source

| Diff

· /leahi_dialin/common/td_defs_proxy.py

(-0, +61)

| History

| Source

· /leahi_dialin/common/test_config_defs.py

(-2, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-46, +46)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-22, +17)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-9, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-14, +14)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-2, +4)

| History

| Source

| Diff

… 46 more files in changeset.

LEAHI-DIALIN-LDT-3557-1: started by Dara Navaei

Dara Navaei — Fri, 20 Feb 2026 10:46:38 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-2004-1: closed by Vinayakam Mani

Vinayakam Mani — Fri, 13 Feb 2026 09:37:39 -0800

Vinayakam Mani Closed LEAHI-DIALIN-LDT-2004-1

LEAHI-DIALIN-LDT-2004-1: reviewers finished

Tue, 10 Feb 2026 13:33:16 -0800

Vendor - TEL - Sameer Poyil , Sean Nash and Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-2004-1

LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD

LEAHI-DIALIN-LDT-2004-1: comment by Vendor - TEL - Sameer Poyil "merged staging into dry bicart branch and code ..."

Vendor - TEL - Sameer Poyil — Tue, 10 Feb 2026 11:23:53 -0800

Vendor - TEL - Sameer Poyil replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-2004-1

merged staging into dry bicart branch and code is pushed

LEAHI-DIALIN-LDT-2004-1: comment by Vendor - TEL - Sameer Poyil "New code pushed"

Vendor - TEL - Sameer Poyil — Tue, 10 Feb 2026 11:22:43 -0800

Vendor - TEL - Sameer Poyil replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-2004-1

New code pushed

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): LDT-2004 -updates for using generic method overrides

Vendor - TEL - Sameer Poyil — Tue, 10 Feb 2026 11:17:01 -0800

Vendor - TEL - Sameer Poyil committed be50641 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 27 more in leahi-dialin

LDT-2004 -updates for using generic method overrides

· /leahi_dialin/dd/modules/drybicart.py

(-103, +56)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-2004-1: comment by Zoltan Miskolci "Could you update all the overrides to use the g..."

Zoltan Miskolci — Tue, 10 Feb 2026 09:27:45 -0800

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-2004-1

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

LEAHI-DIALIN-LDT-2004-1: comment by Zoltan Miskolci "This is not the code that is currently on stagi..."

Zoltan Miskolci — Tue, 10 Feb 2026 09:26:15 -0800

Zoltan Miskolci replied to Vendor - TEL - Sameer Poyil in LEAHI-DIALIN-LDT-2004-1

This is not the code that is currently on staging, so I think you need to update it from there

LEAHI-DIALIN-LDT-2004-1: comment by Vendor - TEL - Sameer Poyil "fixed it"

Vendor - TEL - Sameer Poyil — Mon, 09 Feb 2026 20:57:56 -0800

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DIALIN-LDT-2004-1

fixed it

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): LDT-2004 implementing code review comments + test config for drybicart initial fill test in pre-gen

Vendor - TEL - Sameer Poyil — Mon, 09 Feb 2026 20:53:31 -0800

Vendor - TEL - Sameer Poyil committed de2ad38 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 27 more in leahi-dialin

LDT-2004 implementing code review comments + test config for drybicart initial fill test in pre-gen

· /leahi_dialin/common/test_config_defs.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/drybicart.py	(-1, +5)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-2004-1: comment by Vendor - TEL - Sameer Poyil "This is a change from Zoltan and I am updated t..."

Vendor - TEL - Sameer Poyil — Mon, 09 Feb 2026 17:55:26 -0800

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DIALIN-LDT-2004-1

This is a change from Zoltan and I am updated that into my local branch

LEAHI-DIALIN-LDT-2004-1: comment by Vendor - TEL - Sameer Poyil "for Dry Bicart , I have reserved the message ID..."

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 20:11:25 -0800

Vendor - TEL - Sameer Poyil replied to Vendor - TEL - Sameer Poyil in LEAHI-DIALIN-LDT-2004-1

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

LEAHI-DIALIN-LDT-2004-1: comment by Vendor - TEL - Sameer Poyil "This is a merge issue. when I updated the code ..."

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 20:14:55 -0800

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DIALIN-LDT-2004-1

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

LEAHI-DIALIN-LDT-2004-1: comment by Sean Nash "Add a blank line between functions."

Sean Nash — Fri, 06 Feb 2026 10:41:22 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-2004-1

Add a blank line between functions.

LEAHI-DIALIN-LDT-2004-1: comment by Sean Nash "Is this staying? Is all of above replacing thi..."

Sean Nash — Fri, 06 Feb 2026 09:37:11 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-2004-1

Is this staying? Is all of above replacing this class?

LEAHI-DIALIN-LDT-2004-1: comment by Zoltan Miskolci "Based on the msg id, it should be here"

Zoltan Miskolci — Tue, 03 Feb 2026 14:05:11 -0800

Zoltan Miskolci replied to Vendor - TEL - Sameer Poyil in LEAHI-DIALIN-LDT-2004-1

Based on the msg id, it should be here

LEAHI-DIALIN-LDT-2004-1: comment by Vendor - TEL - Sameer Poyil "@zoltan , could you please confirm whether this..."

Vendor - TEL - Sameer Poyil — Tue, 03 Feb 2026 13:30:15 -0800

Vendor - TEL - Sameer Poyil commented on LEAHI-DIALIN-LDT-2004-1

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

LEAHI-DIALIN-LDT-2004-1: reviewers resumed

Tue, 03 Feb 2026 11:54:23 -0800

Michael Garthwaite resumed reviewing LEAHI-DIALIN-LDT-2004-1

LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD

LEAHI-DIALIN-LDT-2004-1: comment by Zoltan Miskolci "Please pull the latest staging and update the t..."

Zoltan Miskolci — Tue, 03 Feb 2026 09:08:54 -0800

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-2004-1

Please pull the latest staging and update the test configs regarding that.
I think the dry bicart test config is already there

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): LDT-2004 dialyn updates for drybicart

Vendor - TEL - Sameer Poyil — Mon, 02 Feb 2026 16:00:25 -0800

Vendor - TEL - Sameer Poyil committed e2b4c56 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 27 more in leahi-dialin

LDT-2004 dialyn updates for drybicart

· /leahi_dialin/dd/modules/drybicart.py

(-2, +37)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-2004-1: comment by Vendor - TEL - Sameer Poyil "wrong valve name used , it should be spv"

Vendor - TEL - Sameer Poyil — Sat, 17 Jan 2026 15:28:20 -0800

Vendor - TEL - Sameer Poyil commented on LEAHI-DIALIN-LDT-2004-1

wrong valve name used , it should be spv

LEAHI-DIALIN-LDT-2004-1: reviewers resumed

Wed, 14 Jan 2026 22:13:58 -0800

Vendor - TEL - Varshini Nagabooshanam resumed reviewing LEAHI-DIALIN-LDT-2004-1

LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD