Fisheye on leahi-dialin/leahi_dialin/fp/modules/valves.py

LEAHI-DIALIN-LDT-2655-1: reviewers finished

Mon, 30 Mar 2026 09:39:06 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

leahi-dialin (develop): Merge branch 'LDT-3218-update-iofp-permeate-target-flow' into develop

Michael Garthwaite — Thu, 26 Mar 2026 18:29:32 -0700

Michael Garthwaite committed 1b36df7 on branch develop in leahi-dialin

Merge branch 'LDT-3218-update-iofp-permeate-target-flow' into develop

· /leahi_dialin/fp/modules/valves.py

(-0, +28)

| History

| Source

| Diff

leahi-dialin (LDT-3218-update-iofp-permeate-target-flow): LDT-3218: added valve recovery config method

Michael Garthwaite — Thu, 26 Mar 2026 18:29:24 -0700

Michael Garthwaite committed 85af425 on branch LDT-3218-update-iofp-permeate-target-flow, develop in leahi-dialin

LDT-3218: added valve recovery config method

· /leahi_dialin/fp/modules/valves.py

(-0, +28)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-3218-1: started by Dara Navaei

Dara Navaei — Thu, 26 Mar 2026 12:16:59 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3218-1

LEAHI-DIALIN-LDT-3629-2: closed by Zoltan Miskolci

Zoltan Miskolci — Mon, 23 Mar 2026 09:13:46 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3629-2

LEAHI-DIALIN-LDT-3629-2: reviewers finished

Wed, 18 Mar 2026 13:27:23 -0700

Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-2

LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list

LEAHI-DIALIN-LDT-3629-2: comment by Raghu Kallala "update params"

Raghu Kallala — Tue, 17 Mar 2026 07:05:16 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-2

update params

leahi-dialin (develop): Merge branch 'LDT-3629-valve_states_enum_key_rename' into develop

Zoltan Miskolci — Mon, 16 Mar 2026 14:09:17 -0700

Zoltan Miskolci committed fe60234 on branch develop in leahi-dialin

Merge branch 'LDT-3629-valve_states_enum_key_rename' into develop

· /leahi_dialin/common/msg_ids.py	(-1, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/valves.py	(-3, +3)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3629-2: started by Dara Navaei

Dara Navaei — Mon, 16 Mar 2026 12:06:59 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3629-2

leahi-dialin (feature/LDT-3800-enhancements-usability-requests): renamed dict keys

Zoltan Miskolci — Mon, 16 Mar 2026 11:53:00 -0700

Zoltan Miskolci committed d089b54 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3218-update-iofp-permeate-target-flow and 11 more in leahi-dialin

renamed dict keys

· /leahi_dialin/dd/modules/heaters.py	(-1, +0)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/valves.py	(-3, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/valves.py	(-3, +3)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..."

Michael Garthwaite — Mon, 16 Mar 2026 10:04:25 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

LEAHI-DIALIN-LDT-3629-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 12 Mar 2026 14:32:23 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3629-1

LEAHI-DIALIN-LDT-3629-1: reviewers finished

Thu, 12 Mar 2026 14:12:47 -0700

Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-1

LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list

leahi-dialin (LDT-2655-fix_conductivity_override): Merge branch 'staging' into LDT-2655-fix_conductivity_override

Michael Garthwaite — Thu, 12 Mar 2026 14:03:32 -0700

Michael Garthwaite committed 20c66b3 on branch LDT-2655-fix_conductivity_override, develop in leahi-dialin

Merge branch 'staging' into LDT-2655-fix_conductivity_override

· /leahi_dialin/common/__init__.py	(-4, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/valves.py	(-134, +98)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/water_pumps.py	(-72, +40)	\| History	\| Source	\| Diff
· /leahi_dialin/protocols/CAN.py	(-16, +0)	\| History	\| Source	\| Diff
· /leahi_dialin/protocols/__init__.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/__init__.py	(-1, +1)	\| History	\| Source	\| Diff
· /tests/data_capture_helpers/fp_helpers.py	(-5, +8)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "Fixed"

Zoltan Miskolci — Thu, 12 Mar 2026 11:50:16 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

Fixed

LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "added Todo comment"

Zoltan Miskolci — Thu, 12 Mar 2026 11:48:59 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

added Todo comment

LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "They were added while debugging fp_test_configs..."

Zoltan Miskolci — Thu, 12 Mar 2026 11:47:16 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

They were added while debugging fp_test_configs and why it's never being updated.
Removed.

LEAHI-DIALIN-LDT-3629-1: comment by Michael Garthwaite "tip: use the logger and set the statement to er..."

Michael Garthwaite — Thu, 12 Mar 2026 10:59:15 -0700

Michael Garthwaite replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

tip: use the logger and set the statement to error level and you can see it in runtime

leahi-dialin (develop): Merge branch 'LDT-3629-fp_dd_valve_states_enum_fix' into develop

Zoltan Miskolci — Thu, 12 Mar 2026 09:53:50 -0700

Zoltan Miskolci committed bd0012f on branch develop in leahi-dialin

Merge branch 'LDT-3629-fp_dd_valve_states_enum_fix' into develop

· /leahi_dialin/fp/modules/ro_pump.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/temperatures.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/valves.py	(-8, +8)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "pressure limit will be unsigned int not signed ..."

Raghu Kallala — Thu, 12 Mar 2026 09:49:11 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

pressure limit will be unsigned int not signed int with LDT-473..beta CR
Add a TODO to update once the 473 is ready to merge

LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "Are these print statements add for debugging? ..."

Raghu Kallala — Thu, 12 Mar 2026 09:45:48 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

Are these print statements add for debugging?
If not, is this allowed

LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "typo, PUMP_ON_STATE"

Raghu Kallala — Thu, 12 Mar 2026 09:36:55 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

typo, PUMP_ON_STATE

leahi-dialin (feature/LDT-3800-enhancements-usability-requests): - Added FPPumpStates enum - Fixed valves_state_enum length - Fixed pressure sensor struct type

Zoltan Miskolci — Tue, 10 Mar 2026 15:43:08 -0700

Zoltan Miskolci committed 9f94793 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 16 more in leahi-dialin

- Added FPPumpStates enum - Fixed valves_state_enum length - Fixed pressure sensor struct type

· /leahi_dialin/common/fp_defs.py	(-4, +23)	\| History	\| Source	\| Diff
· /leahi_dialin/common/fp_defs_proxy.py	(-0, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/valves.py	(-6, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/boost_pump.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/fp_test_configs.py	(-4, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/ro_pump.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/temperatures.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/valves.py	(-8, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/pressure_sensors.py	(-5, +32)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3629-1: started by Dara Navaei

Dara Navaei — Tue, 10 Mar 2026 11:48:46 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3629-1

LEAHI-DIALIN-LDT-3557-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 05 Mar 2026 10:46:36 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3557-1

leahi-dialin (develop): Merge branch 'LDT-3557-doc_header_for_vars' into develop

Zoltan Miskolci — Thu, 05 Mar 2026 10:37:39 -0800

Zoltan Miskolci committed fc671af on branch develop in leahi-dialin

Merge branch 'LDT-3557-doc_header_for_vars' into develop

· /leahi_dialin/common/__init__.py	(-3, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/common/td_defs.py	(-47, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/common/test_config_defs.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/gen_dialysate.py	(-6, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/temperature_sensors.py	(-9, +11)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/filtration_purification.py	(-38, +39)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/ro_pump.py	(-3, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/temperatures.py	(-2, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/valves.py	(-32, +15)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/water_pumps.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/air_pump.py	(-3, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/air_trap.py	(-4, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/ejector.py	(-2, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-35, +35)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Thu, 05 Mar 2026 10:25:20 -0800

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

LEAHI-DIALIN-LDT-2655-1: reviewers joined LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei joined LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: reviewers removed from LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Tue, 03 Mar 2026 16:58:49 -0800

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables