Fisheye on leahi-dialin/leahi_dialin/td/treatment_delivery.py

LEAHI-DIALIN-LDT-2655-1: reviewers finished

Mon, 30 Mar 2026 09:39:06 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..."

Michael Garthwaite — Mon, 16 Mar 2026 10:04:25 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

LEAHI-DIALIN-LDT-3557-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 05 Mar 2026 10:46:36 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3557-1

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): Merge branch 'LDT-3557-doc_header_for_vars' into staging

Zoltan Miskolci — Thu, 05 Mar 2026 10:42:59 -0800

Zoltan Miskolci committed 3f6c0e9 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 24 more in leahi-dialin

Merge branch 'LDT-3557-doc_header_for_vars' into staging

· /leahi_dialin/common/td_defs.py	(-47, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/common/test_config_defs.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/air_pump.py	(-3, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/air_trap.py	(-4, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-35, +35)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-2759-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 05 Mar 2026 10:41:21 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-2759-1

leahi-dialin (develop): Merge branch 'LDT-3557-doc_header_for_vars' into develop

Zoltan Miskolci — Thu, 05 Mar 2026 10:37:39 -0800

Zoltan Miskolci committed fc671af on branch develop in leahi-dialin

Merge branch 'LDT-3557-doc_header_for_vars' into develop

· /leahi_dialin/common/__init__.py	(-3, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/common/td_defs.py	(-47, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/common/test_config_defs.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/gen_dialysate.py	(-6, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/temperature_sensors.py	(-9, +11)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/filtration_purification.py	(-38, +39)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/ro_pump.py	(-3, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/temperatures.py	(-2, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/valves.py	(-32, +15)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/water_pumps.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/air_pump.py	(-3, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/air_trap.py	(-4, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/ejector.py	(-2, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-35, +35)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Thu, 05 Mar 2026 10:25:20 -0800

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

LEAHI-DIALIN-LDT-2759-1: reviewers finished

Wed, 04 Mar 2026 14:03:13 -0800

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-2759-1

LEAHI-DIALIN-LDT-2759_ Software reset does not take effect immediatly

LEAHI-DIALIN-LDT-2655-1: reviewers joined LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei joined LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: reviewers removed from LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Tue, 03 Mar 2026 16:58:49 -0800

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

LEAHI-DIALIN-LDT-2759-1: reviewers finished

Tue, 03 Mar 2026 16:58:23 -0800

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-2759-1

LEAHI-DIALIN-LDT-2759_ Software reset does not take effect immediatly

LEAHI-DIALIN-LDT-3557-1: comment by Zoltan Miskolci "removed"

Zoltan Miskolci — Tue, 03 Mar 2026 15:28:18 -0800

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-3557-1

removed

LEAHI-DIALIN-LDT-2759-1: started by Dara Navaei

Dara Navaei — Tue, 03 Mar 2026 15:23:40 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-2759-1

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): - td reset fix - alarm list update

Zoltan Miskolci — Tue, 03 Mar 2026 14:00:17 -0800

Zoltan Miskolci committed 4e01203 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 24 more in leahi-dialin

- td reset fix - alarm list update

· /leahi_dialin/common/alarm_defs.py	(-98, +168)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-1, +8)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3557-1: comment by Michael Garthwaite "Remove this extra line"

Michael Garthwaite — Tue, 03 Mar 2026 09:13:22 -0800

Michael Garthwaite commented on LEAHI-DIALIN-LDT-3557-1

Remove this extra line

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): - Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TE...

Zoltan Miskolci — Wed, 25 Feb 2026 18:57:01 -0800

Zoltan Miskolci committed 20c821b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 24 more in leahi-dialin

- Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

· /leahi_dialin/common/__init__.py

(-3, +3)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs.py

(-49, +1)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs_proxy.py

(-0, +63)

| History

| Source

· /leahi_dialin/common/fp_defs.py

(-37, +1)

| History

| Source

| Diff

· /leahi_dialin/common/fp_defs_proxy.py

(-0, +51)

| History

| Source

· /leahi_dialin/common/td_defs.py

(-47, +1)

| History

| Source

| Diff

· /leahi_dialin/common/td_defs_proxy.py

(-0, +61)

| History

| Source

· /leahi_dialin/common/test_config_defs.py

(-2, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-46, +46)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-22, +17)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-9, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-14, +14)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-2, +4)

| History

| Source

| Diff

… 46 more files in changeset.

LEAHI-DIALIN-LDT-3557-1: started by Dara Navaei

Dara Navaei — Fri, 20 Feb 2026 10:46:38 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3287-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 11 Feb 2026 11:33:21 -0800

Michael Garthwaite Closed LEAHI-DIALIN-LDT-3287-1

LEAHI-DIALIN-LDT-3287-1: reviewers finished

Wed, 11 Feb 2026 10:10:35 -0800

Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-3287-1

LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0

LEAHI-DIALIN-LDT-3287-1: comment by Michael Garthwaite "reverted handler to the original version. This ..."

Michael Garthwaite — Wed, 11 Feb 2026 09:10:30 -0800

Michael Garthwaite replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-3287-1

reverted handler to the original version. This was required to get a merge with develop to work

LEAHI-DIALIN-LDT-3287-1: comment by Michael Garthwaite "fixed."

Michael Garthwaite — Wed, 11 Feb 2026 09:09:46 -0800

Michael Garthwaite replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-3287-1

fixed.

LEAHI-DIALIN-LDT-3287-1: comment by Zoltan Miskolci "This code won't work. The sensor list missing t..."

Zoltan Miskolci — Tue, 10 Feb 2026 15:38:11 -0800

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-3287-1

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete.

Please reference https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 for working solution on this.

LEAHI-DIALIN-LDT-3287-1: comment by Zoltan Miskolci "Duplicate, please remove"

Zoltan Miskolci — Tue, 10 Feb 2026 15:34:38 -0800

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-3287-1

Duplicate, please remove

LEAHI-DIALIN-LDT-3287-1: reviewers resumed

Mon, 09 Feb 2026 16:20:55 -0800

Sean Nash resumed reviewing LEAHI-DIALIN-LDT-3287-1

LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): LDT-3287: Reworked the initial message to be a login command instead of a blank ACK message

Michael Garthwaite — Mon, 09 Feb 2026 09:19:14 -0800

Michael Garthwaite committed b9e9c44 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 28 more in leahi-dialin

LDT-3287: Reworked the initial message to be a login command instead of a blank ACK message

· /leahi_dialin/dd/dialysate_delivery.py	(-10, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/filtration_purification.py	(-10, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-10, +3)	\| History	\| Source	\| Diff

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): WIP on develop...

Michael Garthwaite — Thu, 05 Feb 2026 13:26:27 -0800

Michael Garthwaite committed 1ca6328 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 28 more in leahi-dialin

WIP on develop

LDT-3287: added message sent for TD. trimmed documentation

· /leahi_dialin/dd/dialysate_delivery.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/filtration_purification.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-0, +10)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3287-1: started by Dara Navaei

Dara Navaei — Thu, 05 Feb 2026 11:32:24 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-3287-1

LEAHI-DIALIN-LDT-3214-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 22 Jan 2026 10:07:41 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3214-1

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): Merge branch 'LDT-3214-override-refactor' into staging

Zoltan Miskolci — Thu, 22 Jan 2026 10:06:19 -0800

Zoltan Miskolci committed c5bfcf8 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 39 more in leahi-dialin

Merge branch 'LDT-3214-override-refactor' into staging

· /leahi_dialin/common/dd_defs.py

(-6, +15)

| History

| Source

| Diff

· /leahi_dialin/common/fp_defs.py

(-0, +2)

| History

| Source

| Diff

· /leahi_dialin/common/msg_ids.py

(-1, +3)

| History

| Source

| Diff

· /leahi_dialin/common/test_config_defs.py

(-2, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-60, +60)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-31, +157)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-175, +136)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-146, +72)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-104, +48)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-136, +72)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-7, +13)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-149, +66)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-91, +63)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-54, +50)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-110, +59)

| History

| Source

| Diff

… 32 more files in changeset.