Fisheye on dgfirmware/firmware/DG.dil https://devapps.diality.us/changelog/~br%3Dmaster/dgfirmware/firmware/DG.dil Recent activity in "dgfirmware" under directory /firmware/DG.dil DG-DEN-16565-1: closed by Dara Navaei Fri, 15 Nov 2024 12:58:01 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16565-1 https://devapps.diality.us/cru/DG-DEN-16565-1 Dara Navaei Closed DG-DEN-16565-1 ]]> DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-16565-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 06 Jun 2024 10:48:28 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19786 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19786 Sean Nash replied to Sean Nash in DG-DEN-16565-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16565-1: comment by Sean Nash "Can we get by with just 1 msg? Add doxygen com..." Thu, 06 Jun 2024 10:46:24 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19785 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19785 Sean Nash commented on DG-DEN-16565-1

Can we get by with just 1 msg? Add doxygen comments.

]]> DG-DEN-16565-1: comment by Vinayakam Mani "we need to take care of existing stack size whi..." Fri, 24 May 2024 11:59:33 -0700 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16565-1/#c19780 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19780 Vinayakam Mani commented on DG-DEN-16565-1

we need to take care of existing stack size while we merge the bootloader changes. the current stack size is 0x3400, not 0x4C00.

]]> DG-DEN-16204-2: closed by Dara Navaei Mon, 13 May 2024 14:03:05 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16204-2 https://devapps.diality.us/cru/DG-DEN-16204-2 Dara Navaei Closed DG-DEN-16204-2 ]]> DG-DEN-16204-2: reviewers finished Mon, 13 May 2024 10:05:16 -0700 https://devapps.diality.us/cru/DG-DEN-16204-2 https://devapps.diality.us/cru/DG-DEN-16204-2 Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16204-2 DG-DEN-16204_UI FW Pure Water Mode Turning ON Intermittently P1 Staging ]]> DG-DEN-16204-2: started by Dara Navaei Fri, 10 May 2024 17:29:36 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16204-2 https://devapps.diality.us/cru/DG-DEN-16204-2 Dara Navaei started review DG-DEN-16204-2 ]]> DG-DEN-16204-1: closed by Dara Navaei Fri, 10 May 2024 15:10:30 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16204-1 https://devapps.diality.us/cru/DG-DEN-16204-1 Dara Navaei Closed DG-DEN-16204-1 ]]> DG-DEN-16204-1: reviewers finished Fri, 10 May 2024 10:43:29 -0700 https://devapps.diality.us/cru/DG-DEN-16204-1 https://devapps.diality.us/cru/DG-DEN-16204-1 Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16204-1 DG-DEN-16204_UI FW Pure Water Mode Turning Intermittently Staging ]]> dgfirmware (release/p1b/staging): DEN-16204 stack optimization Mon, 06 May 2024 09:55:21 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dgfirmware?cs=62799078ada8ee0cb91c510720d3c978fafcf5f7 https://devapps.diality.us/changelog/dgfirmware?cs=62799078ada8ee0cb91c510720d3c978fafcf5f7 Vinayakam Mani committed 6279907 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 20 more in dgfirmware DEN-16204 stack optimization

· /firmware/DG.dil (-12, +12) | History | Source | Diff
· /firmware/include/sys_core.h (-3, +3) | History | Source | Diff
· /firmware/source/sys_core.asm (-6, +6) | History | Source | Diff
· /firmware/source/sys_link.cmd (-4, +4) | History | Source | Diff
]]> DG-DEN-16204-1: started by Dara Navaei Thu, 02 May 2024 10:24:57 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16204-1 https://devapps.diality.us/cru/DG-DEN-16204-1 Dara Navaei started review DG-DEN-16204-1 ]]> DG-DEN-16565-1: comment by Sean Nash "Is bootloader going to use fwcommon code? Is #..." Tue, 02 Jan 2024 14:15:55 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19340 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19340 Sean Nash commented on DG-DEN-16565-1

Is bootloader going to use fwcommon code? Is #ifdef #else backwards?

]]> DG-DEN-16565-1: comment by Sean Nash "Needed?" Tue, 02 Jan 2024 14:14:57 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19339 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19339 Sean Nash commented on DG-DEN-16565-1

Needed?

]]> DG-DEN-16565-1: comment by Sean Nash "This is not user code. Next regen will restore..." Tue, 02 Jan 2024 14:13:25 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19338 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19338 Sean Nash commented on DG-DEN-16565-1

This is not user code. Next regen will restore this code. Do we really need to disable ECC test code?

]]> DG-DEN-16565-1: comment by Sean Nash "This is not user code. Next regen will restore..." Tue, 02 Jan 2024 14:12:25 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19337 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19337 Sean Nash commented on DG-DEN-16565-1

This is not user code. Next regen will restore this code. Do we really need to remove this code?

]]> DG-DEN-16565-1: comment by Sean Nash "What is this code doing? Why no comments? Is ..." Tue, 02 Jan 2024 14:11:49 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19336 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19336 Sean Nash commented on DG-DEN-16565-1

What is this code doing? Why no comments? Is it necessary?

]]> DG-DEN-16565-1: comment by Sean Nash "#if 1 and #endif appear to be unnecessary. Rem..." Tue, 02 Jan 2024 14:11:05 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19335 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19335 Sean Nash commented on DG-DEN-16565-1

#if 1 and #endif appear to be unnecessary. Remove.

]]> DG-DEN-16565-1: comment by Sean Nash "Remove duplicate user code start comment." Tue, 02 Jan 2024 14:10:15 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19334 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19334 Sean Nash commented on DG-DEN-16565-1

Remove duplicate user code start comment.

]]> DG-DEN-16565-1: comment by Sean Nash "This is not user code. Next regen will restore..." Tue, 02 Jan 2024 14:09:15 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19332 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19332 Sean Nash commented on DG-DEN-16565-1

This is not user code. Next regen will restore this code. Do we really need to disable ECC error handling?

]]> DG-DEN-16565-1: comment by Sean Nash "This is not user code. Next regen will restore..." Tue, 02 Jan 2024 14:08:15 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19331 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19331 Sean Nash commented on DG-DEN-16565-1

This is not user code. Next regen will restore this code. Do we really need to disable this?

]]> DG-DEN-16565-1: comment by Sean Nash "Why one handler for 3 commands?" Tue, 02 Jan 2024 14:07:07 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19330 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19330 Sean Nash commented on DG-DEN-16565-1

Why one handler for 3 commands?

]]> DG-DEN-16565-1: comment by Sean Nash "Why aren't we calling the specific handlers for..." Fri, 22 Dec 2023 09:37:08 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16565-1/#c19328 https://devapps.diality.us/cru/DG-DEN-16565-1/#c19328 Sean Nash commented on DG-DEN-16565-1

Why aren't we calling the specific handlers for reboot and enter bootloader commands?

]]> DG-DEN-16565-1: reviewers added to DG-DEN-16565_SW Updater HD DG App Side Intake From... Fri, 22 Dec 2023 09:32:41 -0800 https://devapps.diality.us/cru/DG-DEN-16565-1 https://devapps.diality.us/cru/DG-DEN-16565-1 Sean Nash added Dana Rich to DG-DEN-16565-1 DG-DEN-16565_SW Updater HD DG App Side Intake From Sunrise ]]> DG-DEN-16565-1: started by Dara Navaei Mon, 18 Dec 2023 11:24:45 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16565-1 https://devapps.diality.us/cru/DG-DEN-16565-1 Dara Navaei started review DG-DEN-16565-1 ]]> DG-COMMON-FIX-1: closed by Dara Navaei Thu, 19 Oct 2023 08:43:59 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1 Dara Navaei Closed DG-COMMON-FIX-1 ]]> DG-COMMON-FIX-1: reviewers finished Thu, 19 Oct 2023 08:43:51 -0700 https://devapps.diality.us/cru/DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1 Dara Navaei finished reviewing DG-COMMON-FIX-1 DG-COMMON-FIX_Review ]]> DG-COMMON-FIX-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:43:46 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19114 https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19114 Dara Navaei replied to pmontazemi  (deleted user) in DG-COMMON-FIX-1

RESOLVED in CODE WALKTHROUGH

]]> DG-COMMON-FIX-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:43:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19113 https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19113 Dara Navaei replied to pmontazemi  (deleted user) in DG-COMMON-FIX-1

RESOLVED in CODE WALKTHROUGH

]]> DG-COMMON-FIX-1: started by Dara Navaei Thu, 19 Oct 2023 08:43:00 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1 Dara Navaei started review DG-COMMON-FIX-1 ]]>