Fisheye on dialin/tools/install_to_venv.sh https://devapps.diality.us/changelog/~br%3Drelease%25402fp1b%25402fdevelop/dialin/tools/install_to_venv.sh Recent activity in "dialin" under directory /tools/install_to_venv.sh DIALIN-DENBUG-280-4: closed by Michael Garthwaite Wed, 06 Nov 2024 15:20:04 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 Michael Garthwaite Closed DIALIN-DENBUG-280-4 ]]> DIALIN-DENBUG-280-1: closed by Michael Garthwaite Wed, 06 Nov 2024 15:19:54 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Michael Garthwaite Closed DIALIN-DENBUG-280-1 ]]> DIALIN-DENBUG-280-4: reviewers finished Mon, 04 Nov 2024 10:29:29 -0800 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 Sean Nash finished reviewing DIALIN-DENBUG-280-4 DIALIN-DENBUG-280_Issues With HD Broadcast P1 ]]> DIALIN-DENBUG-280-4: started by Dara Navaei Sat, 02 Nov 2024 16:01:22 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 Dara Navaei started review DIALIN-DENBUG-280-4 ]]> DIALIN-DENBUG-280-1: reviewers joined DIALIN-DENBUG-280_Issues With HD Broadcast P1B Thu, 31 Oct 2024 11:03:43 -0700 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Dara Navaei joined DIALIN-DENBUG-280-1 DIALIN-DENBUG-280_Issues With HD Broadcast P1B ]]> DIALIN-DENBUG-280-1: reviewers removed from DIALIN-DENBUG-280_Issues With HD Broadcast P1B Thu, 31 Oct 2024 11:03:43 -0700 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Dara Navaei removed Michael Garthwaite from DIALIN-DENBUG-280-1 DIALIN-DENBUG-280_Issues With HD Broadcast P1B ]]> DIALIN-DENBUG-280-1: started by Dara Navaei Thu, 31 Oct 2024 11:02:51 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Dara Navaei started review DIALIN-DENBUG-280-1 ]]> DIALIN-DIAL-299-1: closed by Michael Garthwaite Mon, 01 Jul 2024 10:16:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DIAL-299-1 https://devapps.diality.us/cru/DIALIN-DIAL-299-1 Michael Garthwaite Closed DIALIN-DIAL-299-1 ]]> DIALIN-DIAL-299-1: comment by Michael Garthwaite "This CR should be closed due to bad branching. ..." Mon, 01 Jul 2024 10:16:33 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DIAL-299-1/#c19797 https://devapps.diality.us/cru/DIALIN-DIAL-299-1/#c19797 Michael Garthwaite commented on DIALIN-DIAL-299-1

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

]]> DIALIN-DIAL-299-1: started by Dara Navaei Wed, 26 Jun 2024 12:01:20 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DIAL-299-1 https://devapps.diality.us/cru/DIALIN-DIAL-299-1 Dara Navaei started review DIALIN-DIAL-299-1 ]]> DIALIN-DEN-4856-1: closed by plucia Fri, 16 Oct 2020 14:42:41 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4856-1 https://devapps.diality.us/cru/DIALIN-DEN-4856-1 plucia  (deleted user) Closed DIALIN-DEN-4856-1 ]]> DIALIN-DEN-4856-1: reviewers finished Fri, 16 Oct 2020 14:41:32 -0700 https://devapps.diality.us/cru/DIALIN-DEN-4856-1 https://devapps.diality.us/cru/DIALIN-DEN-4856-1 qnguyen  (deleted user) and Sean Nash finished reviewing DIALIN-DEN-4856-1 DIALIN-DEN-4856_Sprint_27 ]]> DIALIN-DEN-4856-1: comment by qnguyen "RESOLVED." Wed, 14 Oct 2020 17:26:05 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5538 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5538 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-4856-1

RESOLVED.

]]> DIALIN-DEN-4856-1: comment by qnguyen "RESOLVED." Wed, 14 Oct 2020 16:22:51 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5537 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5537 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-4856-1

RESOLVED.

]]> DIALIN-DEN-4856-1: comment by qnguyen "RESOLVED." Wed, 14 Oct 2020 16:22:33 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5536 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5536 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-4856-1

RESOLVED.

]]> DIALIN-DEN-4856-1: comment by plucia "The version of crucible we're using has an issu..." Wed, 14 Oct 2020 15:59:06 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5535 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5535 plucia  (deleted user) replied to qnguyen  (deleted user) in DIALIN-DEN-4856-1

The version of crucible we're using has an issue where duplicate files show in the file viewer on the left.

If you look at the more recent hemodialysis_device.py file (see the files viewer on the left), this message id is removed: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19219

It is also removed from both msg_defs.py: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19027 and http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19203

]]> DIALIN-DEN-4856-1: comment by plucia "Done" Wed, 14 Oct 2020 15:57:59 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5534 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5534 plucia  (deleted user) replied to qnguyen  (deleted user) in DIALIN-DEN-4856-1

Done

]]> DIALIN-DEN-4856-1: comment by plucia "Yes, if it's already there no reason to remove ..." Wed, 14 Oct 2020 15:57:21 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5533 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5533 plucia  (deleted user) replied to qnguyen  (deleted user) in DIALIN-DEN-4856-1

Yes, if it's already there no reason to remove it. I've added it back

]]> DIALIN-DEN-4856-1: comment by qnguyen "This message id is not being used." Mon, 12 Oct 2020 09:18:58 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5430 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5430 qnguyen  (deleted user) commented on DIALIN-DEN-4856-1

This message id is not being used.

]]> DIALIN-DEN-4856-1: comment by qnguyen "The file should be renamed to match this." Mon, 12 Oct 2020 09:16:33 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5429 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5429 qnguyen  (deleted user) commented on DIALIN-DEN-4856-1

The file should be renamed to match this.

]]> DIALIN-DEN-4856-1: comment by qnguyen "should we keep the copyright?" Mon, 12 Oct 2020 09:13:45 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5428 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5428 qnguyen  (deleted user) commented on DIALIN-DEN-4856-1

should we keep the copyright?

]]> DIALIN-DEN-4856-1: started by plucia Wed, 07 Oct 2020 11:54:36 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4856-1 https://devapps.diality.us/cru/DIALIN-DEN-4856-1 plucia  (deleted user) started review DIALIN-DEN-4856-1 ]]> DIALIN-2: closed by plucia Wed, 30 Sep 2020 13:34:56 -0700 plucia https://devapps.diality.us/cru/DIALIN-2 https://devapps.diality.us/cru/DIALIN-2 plucia  (deleted user) Closed DIALIN-2 ]]> DIALIN-2: reviewers finished Wed, 30 Sep 2020 13:34:23 -0700 https://devapps.diality.us/cru/DIALIN-2 https://devapps.diality.us/cru/DIALIN-2 Sean Nash and Behrouz NematiPour finished reviewing DIALIN-2 Dialin DEN-4589_Sprint_26 ]]> DIALIN-2: comment by Behrouz NematiPour "Good, So please consider cleaning up used libr..." Wed, 30 Sep 2020 12:11:57 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-2/#c5003 https://devapps.diality.us/cru/DIALIN-2/#c5003 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-2

Good,
So please consider cleaning up used libraries periodically.

RESOLVED.

]]> DIALIN-2: comment by Behrouz NematiPour "RESOLVED" Wed, 30 Sep 2020 12:10:13 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-2/#c5002 https://devapps.diality.us/cru/DIALIN-2/#c5002 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-2

RESOLVED

]]> DIALIN-2: comment by plucia "1 - pip uses requirements.txt to install depend..." Wed, 09 Sep 2020 10:46:00 -0700 plucia https://devapps.diality.us/cru/DIALIN-2/#c4572 https://devapps.diality.us/cru/DIALIN-2/#c4572 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-2

1 - pip uses requirements.txt to install dependencies. See tools/setup_environment.sh for more detail.
2 - What you're asking about is the offline install capability. I have created a ticket in Jira http://dvm-linux02:8080/browse/DIAL-34 to track this new feature request.
3 - The offline install capability addresses this situation, in the (very) unlikely event that pypi hosting can't be relied upon.
4 - No. My understanding is that we do not need to validate these libraries because Dialin is NPSW.
5 - It's fine to have all of these libraries. For example, some of them are dependencies of python-can. Periodically this requirements.txt will be cleaned if a library is no longer being used. For this change-set, I added flake8 so we can run static code analysis. Flake8 is installed along with its dependencies.

]]> DIALIN-2: comment by plucia "I have updated it so it says Dialin now." Wed, 09 Sep 2020 10:44:10 -0700 plucia https://devapps.diality.us/cru/DIALIN-2/#c4571 https://devapps.diality.us/cru/DIALIN-2/#c4571 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-2

I have updated it so it says Dialin now.

]]> DIALIN-2: comment by Behrouz NematiPour "I have some questions regarding these libraries..." Tue, 08 Sep 2020 11:57:14 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-2/#c4460 https://devapps.diality.us/cru/DIALIN-2/#c4460 Behrouz NematiPour commented on DIALIN-2

I have some questions regarding these libraries.
1 - What tool/code is checking for these requirements?
2 - What if the requirement is not met? (not a correct version or lib not exists)
3 - If the lib does not exist is it going to be installed or thrown an error?
4 - Don't we need to validate all these libraries?
5 - What is our process of adding more libraries to the list? On the other way is it fine to have all these libs? are all of them being used?

]]> DIALIN-2: comment by Behrouz NematiPour "Why this code review starts with "UI_" it's all..." Tue, 08 Sep 2020 11:51:54 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-2/#c4459 https://devapps.diality.us/cru/DIALIN-2/#c4459 Behrouz NematiPour commented on DIALIN-2

Why this code review starts with "UI_" it's all Dialin.
Shouldn't it be started with Dialin?

]]>