version.py

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 36 more files in changeset.
RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

In this filename, "prs" means "Product Requirement Specification" and not "Pressure". These values are defined in the PRS and are being used by UI Simulator.

In this filename, "prs" means "Product Requirement Specification" and not "Pressure".
These values are defined in the PRS and are being used by UI Simulator.

Removed the return of CAN frame list.

Removed the return of CAN frame list.

These are no definitions of these class inside alarm_defs.py yet. I think this means PRS definitions rather than pressure. Behrouz NematiPour Should these definitions be moved to another file?

These are no definitions of these class inside alarm_defs.py yet. I think this means PRS definitions rather than pressure.
Behrouz NematiPour Should these definitions be moved to another file?

What does it mean to return two things: frames and message?

What does it mean to return two things: frames and message?

Aren't these alarm enums duplicates of the ones in alarm_defs.py? Also, file name suggests these are pressure related definitions - so why are alarm definitions in here?

Aren't these alarm enums duplicates of the ones in alarm_defs.py? Also, file name suggests these are pressure related definitions - so why are alarm definitions in here?

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Add TODO

Add TODO

Add TODO

Add TODO

CAN instead of can

CAN instead of can

Denali with capital "D".

Denali with capital "D".

DIALIN-DEN-8856_Sprint 47
DIALIN-DEN-8856_Sprint 47
DEN-8856: Use setuptools scm for dialin version

  1. … 4 more files in changeset.
RESOLVED.

RESOLVED.

That's a good idea and I think we should do so. Since this code review is quite old I will make that change in my latest branch

That's a good idea and I think we should do so. Since this code review is quite old I will make that change in my latest branch

should we create dg_defs file?

should we create dg_defs file?

DIALIN-DEN-8462_Sprint 45
DIALIN-DEN-8462_Sprint 45