application / sources / canbus

FrameInterface.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 29 Mar 23
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 15 Nov 2024
12:54 pm

Dara Navaei

Friday 07 Jun 2024
9:05 am

Dara Navaei

9:04 am

Dara Navaei

UI-DEN-SUNRISE
UI-DEN-SUNRISE
Thursday 19 Oct 2023
8:26 pm

pmontazemi  (deleted user)

Thursday 03 Aug 2023
2:23 pm

Sean Nash

2:05 pm

Dara Navaei

Wednesday 02 Aug 2023
9:33 am

Sean Nash

Monday 08 May 2023
8:49 am

Dara Navaei

UI Staging Unreviewed Commits
UI Staging Unreviewed Commits
Friday 10 Feb 2023
9:23 am

Behrouz NematiPour

9:23 am

Michael Garthwaite , vduong  (deleted user) and jishii  (deleted user)

9:17 am

vduong  (deleted user)

Ok, sounds good. RESOLVED

Ok, sounds good.

RESOLVED

8:17 am

Behrouz NematiPour

Good point, I agree with the two intervals, it would be clarifying. For the counter, though, it might not be always the case. I will start doing it in my next task, since I would like to change all...

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

7:40 am

vduong  (deleted user)

Only a suggestion: It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity. For instance, here, we have ms and the next o...

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

7:16 am

vduong  (deleted user)

RESOLVED

RESOLVED

7:12 am

Behrouz NematiPour

Thanks for the feedback. Fixed.

Thanks for the feedback.
Fixed.

7:03 am

vduong  (deleted user)

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

Tuesday 31 Jan 2023
11:22 pm

Behrouz NematiPour

Tuesday 17 Jan 2023
9:01 am

Dara Navaei

UI-DEN-14517_UI BN S88
UI-DEN-14517_UI BN S88
Thursday 08 Sep 2022
3:32 pm

Behrouz NematiPour

3:30 pm

Tiffany Mejia

Tuesday 06 Sep 2022
11:20 am

Michael Garthwaite

Tuesday 12 Jul 2022
11:52 am

Sean Nash

11:51 am

Sean Nash

RESOLVED.

RESOLVED.

Monday 11 Jul 2022
10:01 am

Behrouz NematiPour

Sure Sean, if that is the decision, will do it soon and create a case for that. I also believe some other CL Switches need to be removed, which were only implemented for our testing at the time (CA...

Sure Sean, if that is the decision, will do it soon and create a case for that.
I also believe some other CL Switches need to be removed, which were only implemented for our testing at the time (CANBus).

Issue DEN-13441 - MR: Make the Dialin log permanent with no switch [CL switches review/removal] has been successfully created

Wednesday 06 Jul 2022
9:35 am

Sean Nash

If this is to log Dialin messages, we should always do that (no switch). If a Dialin command is given/responded to, we definitely want to know about that - so want to see it in the log. Dialin comm...

If this is to log Dialin messages, we should always do that (no switch). If a Dialin command is given/responded to, we definitely want to know about that - so want to see it in the log. Dialin commands are always one-shot type messages, so will not impact log size.

9:31 am

Sean Nash

RESOLVED.

RESOLVED.

9:31 am

Sean Nash

RESOLVED.

RESOLVED.

9:03 am

Tiffany Mejia

RESOLVED

RESOLVED

Tuesday 05 Jul 2022
10:19 am

Behrouz NematiPour

This code is going to be used later in the Log Export for slow transfer & confirmation for the USB port slow transfer issue. I kept it in the application repo to keep it safe. Commented out to not ...

This code is going to be used later in the Log Export for slow transfer & confirmation for the USB port slow transfer issue.
I kept it in the application repo to keep it safe.
Commented out to not affect the coverage.

Friday 01 Jul 2022
4:46 pm

Behrouz NematiPour

http://dvm-linux02:8060/cru/#UI-DEN-12716-2CFR-30978 in PostTreatmentReview.qml@40

http://dvm-linux02:8060/cru/#UI-DEN-12716-2CFR-30978
in PostTreatmentReview.qml@40