application

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +1
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h
DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +1
    /sources/model/mtreatmentadjustrequests.h
    • -12
    • +6
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp
DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -7
    • +7
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +2
    /sources/gui/qml/pages/SettingsHome.qml
    • -1
    • +1
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h
    • -3
    • +7
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp
DEN-3157 : Code Coverage

- DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-3156 Integration Testing

- 90.849% (1916/2109)

________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -2
    • +4
    /sources/gui/qml/pages/SettingsHome.qml
    • -1
    • +4
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h
    • -0
    • +2
    /sources/view/vtreatmentultrafiltration.h
DEN-3155 : Unit Testing

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -2
    • +1
    /sources/canbus/messageinterpreter.cpp
    • -1
    • +5
    /sources/view/vtreatmentadjustmentresponsebase.cpp
DEN-3155 : Unit Testing

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +0
    /sources/gui/qml/components/MainMenu.qml
    • -0
    • +2
    /sources/gui/qml/components/ModalDialog.qml
    • -0
    • +2
    /sources/gui/qml/dialogs/AutoHideInfo.qml
DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -2
    • +2
    /sources/gui/qml/components/TouchRect.qml
DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -8
    • +8
    /sources/canbus/messageinterpreter.cpp
DEN-3628 : EMC Test Support

- Adding Temperature sensors values on the settings diagnostic page.

- Applied Code Review comments.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +33
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +39
    /sources/gui/qml/pages/SettingsHome.qml
  1. … 9 more files in changeset.
Merge branch 'DEN-3628_EMCTestSupport' into DEN-3149_TreatmentUltrafiltrationAdjustment

DEN-3628 : EMC Test Support

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -8
    • +75
    /sources/canbus/messageinterpreter.cpp
    • -14
    • +100
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +53
    /sources/model/mloadcellreadings.cpp
    • -0
    • +54
    /sources/model/mloadcellreadings.h
    • -0
    • +27
    /sources/view/vloadcellreadings.cpp
    • -0
    • +38
    /sources/view/vloadcellreadings.h
DEN-3149 : Treatment Ultrafiltration Adjustment

- Updated regarding the demo notes

- Fixed some codes to pass the existing unit tests (other than Ultrafiltration which have to work on it anyway (it's regarding mL=>L))

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-3149 : Treatment Ultrafiltration Adjustment

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-3149 : Treatment Ultrafiltration Adjustment

- The third Code Review by myself

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +1
    /sources/canbus/messageinterpreter.cpp
    • -26
    • +26
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -3
    • +0
    /sources/model/mtreatmentadjustultrafiltrationconfirmresponse.h
    • -3
    • +0
    /sources/model/mtreatmentadjustultrafiltrationeditresponse.h
    • -4
    • +4
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.cpp
    • -3
    • +3
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h
    • -46
    • +0
    /sources/view/vtreatmentadjustmentultrafiltration.cpp
    • -56
    • +0
    /sources/view/vtreatmentadjustmentultrafiltration.h
    • -0
    • +52
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.cpp
    • -0
    • +54
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h
  1. … 9 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- The second Code Review by myself

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -13
    • +3
    /sources/canbus/messagedispatcher.cpp
    • -13
    • +3
    /sources/canbus/messagedispatcher.h
    • -5
    • +2
    /sources/view/vtreatmentadjustmentduration.cpp
    • -5
    • +2
    /sources/view/vtreatmentadjustmentflows.cpp
    • -5
    • +2
    /sources/view/vtreatmentadjustmentultrafiltration.cpp
    • -5
    • +2
    /sources/view/vtreatmentultrafiltrationconfirm.cpp
    • -5
    • +2
    /sources/view/vtreatmentultrafiltrationstate.cpp
DEN-3149 : Treatment Ultrafiltration Adjustment

- The first my myself.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -10
    • +12
    /sources/applicationcontroller.h
    • -1
    • +1
    /sources/gui/qml/components/TouchRect.qml
  1. … 16 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- Fixed a typo

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-3149 : Treatment Ultrafiltration Adjustment

- The resolution added to the Ultrafiltration Volume adjustment.

There is a discrepancy between PRS items which needs to be clarified. But for now 0.100 mL resolution has been selected.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-3149 : Treatment Ultrafiltration Adjustment

- Revert back the Ultrafiltration rate to the mL.

- Added a QT_DEBUG define for the Ultrafiltration volume because usually we are not connected to the pump and measVol would return 0 but RefVol is the calculated vol and should always have a value.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +4
    /sources/view/vtreatmentultrafiltration.cpp
DEN-3149 : Treatment Ultrafiltration Adjustment

- Adding the last Ultrafiltration message transaction to confirm the values.

- Added the modification of the Ultrafiltration Volume unit change.

- Modified the components to support real/float variables to support Ultrafiltration volume with Liter as unit and 3 digit precision.

- So much refactoring

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -30
    • +57
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +3
    /sources/gui/qml/components/ProgressBar.qml
    • -1
    • +1
    /sources/gui/qml/components/ProgressBarEx.qml
    • -2
    • +6
    /sources/gui/qml/components/ProgressRect.qml
    • -1
    • +4
    /sources/gui/qml/components/RangeBar.qml
    • -2
    • +3
    /sources/gui/qml/components/RangeMarker.qml
  1. … 27 more files in changeset.
DEN-3154 : Implementation [ Messaging ]

- Added the Ultrafiltration Adjustment Confirm Request

- Improved the MVC and some twicks in qml.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -59
    • +10
    /sources/applicationcontroller.cpp
    • -0
    • +80
    /sources/canbus/messagedispatcher.cpp
    • -0
    • +14
    /sources/canbus/messagedispatcher.h
    • -2
    • +7
    /sources/canbus/messageinterpreter.cpp
    • -1
    • +1
    /sources/gui/qml/components/TouchRect.qml
  1. … 7 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- Updated the MVC/Messaging with the updated Ultrafiltration Adjustment message.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -4
    • +4
    /sources/model/mtreatmentadjustultrafiltrationresponse.cpp
    • -4
    • +4
    /sources/model/mtreatmentadjustultrafiltrationresponse.h
    • -1
    • +1
    /sources/view/vtreatmentadjustmentultrafiltration.cpp
    • -2
    • +2
    /sources/view/vtreatmentadjustmentultrafiltration.h
DEN-3149 : Treatment Ultrafiltration Adjustment

- Adjustment Models refactoring.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -20
    • +26
    /sources/applicationcontroller.cpp
    • -3
    • +7
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +8
    /sources/model/mtreatmentadjustultrafiltrationresponse.cpp
    • -0
    • +2
    /sources/model/mtreatmentadjustultrafiltrationresponse.h
    • -0
    • +38
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.cpp
  1. … 11 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- Treatment Ultrafiltration Edit => Confirm Screen.

- Added Error notification for the ultrafiltration state/adjustment response on related dialogs.

- Modified the Image/Wave/Clock to have the positioning out of the component.

- Added/Separated the pause notification on the Treatment Adjustment Base Component so the code handling would be easier to handle the pause notification and the error message handling on the dialog.

- Added overloaded text method for the ultrafiltration state although it has no rejection reason.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -5
    • +0
    /sources/gui/qml/components/ImageClock.qml
    • -6
    • +0
    /sources/gui/qml/components/ImageWave.qml
  1. … 4 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- Added selected Ultrafiltration Volume value label in the Ultrafiltration Edit dialog

- Changed notification object exposure logic in TouchArea and ModalDialog.

- Used measuredVolume but passed refVol in C++ to make one place changed,.

- Changed connection call to property binding for the TreatmentUltrafiltration section pause notification.

- Changed the MAdjustUltrafiltrationReq model from U32(quint32) to F32(float).

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -3
    • +1
    /sources/gui/qml/components/ModalDialog.qml
    • -2
    • +2
    /sources/gui/qml/components/ProgressBarEx.qml
    • -8
    • +6
    /sources/gui/qml/components/TouchArea.qml
    • -1
    • +1
    /sources/view/vtreatmentadjustmentultrafiltration.h
    • -1
    • +6
    /sources/view/vtreatmentultrafiltration.cpp
DEN-3149 : Treatment Ultrafiltration Adjustment

- BackUp push:

- Message 19 : UF Vol. Change Response

- Incomplete.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +36
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +2
    /sources/view/vtreatmentadjustmentultrafiltration.cpp
    • -2
    • +4
    /sources/view/vtreatmentadjustmentultrafiltration.h
DEN-3149 : Treatment Ultrafiltration Adjustment

- Added :

. Treatment Adjustment Ultrafiltration Response Model (mtreatmentadjustultrafiltrationresponse)

. Treatment Adjustment Ultrafiltration Response View (vtreatmentadjustmentultrafiltration)

. Treatment Ultrafiltration State Change Request Model (mtreatmentultrafiltrationstate)

. Treatment Ultrafiltration State Change Request View (vtreatmentultrafiltrationstate)

- Added Ultrafiltration Pause / Resume Messaging

- Modified NotificationBar to be able to use it in the Ultrafiltration Section when Ultrafiltration is paused.

- Modified TouchArea to make the TreatmentStart Screen clean. (Removed the Component List logic and layered out the components manually since each section is different and can't apply one rule for all)

- Updated the Ultrafiltration navigation stack regarding the MVC/Messaging responses.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +36
    /sources/canbus/messageinterpreter.cpp
  1. … 30 more files in changeset.
DEN-3149 : Treatment Ultrafiltration Adjustment

- Separeted VTreatmentAdjustmentsResponse into 3 classes and used this class as parent of the two others and this class keeps the Accepted Boolean and the rejection reason.

- The other two keep the actual logic of the Adjustment values/properties.

- Moved the View includes from VView.h into the guiglobals.cpp since when including the vview.h the definition guard didn't let the inheritance work.

- Removed the VTreatmentAdjustmentsResponce from the list of the registered views into QML.

- made the TRIGGER_SLOT and PROPERTY_SLOT as protected so the children can use them.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +31
    /sources/view/vtreatmentadjustmentduration.cpp
    • -0
    • +44
    /sources/view/vtreatmentadjustmentduration.h
    • -0
    • +32
    /sources/view/vtreatmentadjustmentflows.cpp
    • -0
    • +44
    /sources/view/vtreatmentadjustmentflows.h
    • -27
    • +6
    /sources/view/vtreatmentadjustmentsresponse.cpp
    • -18
    • +1
    /sources/view/vtreatmentadjustmentsresponse.h
DEN-3149 : Treatment Ultrafiltration Adjustment

- Added Ultrafiltration button component for the Ultrafiltration Adjustment options

- Added two Clock(+.-) and Wave(+.-) icons for the Ultrafiltration Adjustment options

- Created special components (ImageWave.qml and ImageClock.qml) for each image to encapsulate all the image properties in one component.

- Added Ultrafiltration Adjustment Confirm dialog

- Added Ultrafiltration Adjustment Confirm dialog Navigation.

- Renamed LogoD.qml to ImageLogoD.qml to be consistent with the other Image Components.

- Inverted the slider handler object back and border color to be consistent with the UX design.

- Created the ImageLogoDDarkTransparent.qml for the MainMenu Diality Icon.

- Added disabled property to the TouchRect components.

- Aligned the Slider with the Ultrafiltration ProgressBar.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • binary
    /resources/images/Clock-Minus.png
    • binary
    /resources/images/Clock-Plus.png
    • binary
    /resources/images/Wave-Minus.png
    • binary
    /resources/images/Wave-Plus.png
    • -0
    • +46
    /sources/gui/qml/components/ImageClock.qml
    • -0
    • +39
    /sources/gui/qml/components/ImageLogoD.qml
    • -0
    • +35
    /sources/gui/qml/components/ImageLogoDDarkTransparent.qml
    • -0
    • +47
    /sources/gui/qml/components/ImageWave.qml
    • -38
    • +0
    /sources/gui/qml/components/LogoD.qml
    • -4
    • +1
    /sources/gui/qml/components/MainMenu.qml
    • -8
    • +10
    /sources/gui/qml/components/ProgressBar.qml
    • -2
    • +2
    /sources/gui/qml/components/Slider.qml
    • -0
    • +2
    /sources/gui/qml/components/TouchRect.qml
  1. … 8 more files in changeset.