application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 09 Jul 20
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 09 Jul 2020
8:52 am

Peter Lucia <plucia@diality.com>

Improved readability of main.h

Options
    • -61
    • +114
    /sources/main.h
Tuesday 07 Jul 2020
12:22 pm

Dara Navaei

Updated the Copyright with the current year and replaced tabs with 4 spaces

Options
    • -0
    • +15
    /cppcheck.sh
    • -10
    • +11
    /main.cpp
    • -11
    • +13
    /scripts/copy.sh
    • -12
    • +13
    /scripts/run.sh
    • -10
    • +12
    /scripts/setup.sh
    • -10
    • +11
    /sources/abstract/singleton.h
    • -10
    • +11
    /sources/applicationcontroller.cpp
    • -10
    • +11
    /sources/applicationcontroller.h
    • -10
    • +11
    /sources/applicationpost.cpp
    • -10
    • +11
    /sources/applicationpost.h
    • -13
    • +14
    /sources/canbus/caninterface.cpp
    • -13
    • +14
    /sources/canbus/caninterface.h
    • -9
    • +10
    /sources/canbus/frameinterface.cpp
    • -9
    • +10
    /sources/canbus/frameinterface.h
    • -9
    • +10
    /sources/canbus/messageacknowmodel.cpp
  16. … 184 more files in changeset.
12:01 pm

Peter Lucia <plucia@diality.com>

Put back missing period for Alarm Not Recognized in tst_models.cpp

Options
    • -2
    • +2
    /unittests/tst_models.cpp
Monday 06 Jul 2020
3:18 pm

Peter Lucia <plucia@diality.com>

Updated alarm status messages and added newlines for long messages.

Options
    • -11
    • +11
    /sources/model/malarmstatus.cpp
1:38 pm

Peter Lucia <plucia@diality.com>

Updated message interpreter unit test name

Options
    • -1
    • +1
    /unittests/tst_messaging.cpp
    • -1
    • +1
    /unittests/tst_messaging.h
11:42 am

Peter Lucia <plucia@diality.com>

Updated spacing in Fonts.qml

Options
    • -1
    • +1
    /sources/gui/qml/globals/Fonts.qml
Wednesday 01 Jul 2020
2:10 pm

Peter Lucia <plucia@diality.com>

Added back SquishQt comment

Options
    • -1
    • +1
    /sources/gui/qml/components/NotificationBar.qml
2:09 pm

Peter Lucia <plucia@diality.com>

Fixed MouseArea z order, removed unused sound item

Options
    • -24
    • +24
    /sources/gui/qml/components/SettingsItem.qml
    • -1
    • +6
    /sources/gui/qml/pages/Diagnostics.qml
    • -7
    • +5
    /sources/gui/qml/pages/SettingsHome.qml
1:54 pm

Peter Lucia <plucia@diality.com>

Aligned colors

Options
    • -4
    • +4
    /sources/gui/qml/globals/Colors.qml
1:45 pm

Peter Lucia <plucia@diality.com>

Removed spaces

Options
    • -1
    • +0
    /unittests/tst_messaging.cpp
    • -2
    • +0
    /unittests/tst_models.cpp
    • -1
    • +0
    /unittests/tst_models.h
Monday 29 Jun 2020
4:02 pm

Peter Lucia <plucia@diality.com>

Added explanations to coco begin validated clauses

Options
    • -1
    • +1
    /sources/canbus/messagedispatcher.cpp
    • -1
    • +1
    /sources/view/valarmstatus.cpp
    • -1
    • +1
    /sources/view/valarmstatus.h
3:51 pm

Peter Lucia <plucia@diality.com>

Updated models and messaging tests for 100% code coverage. Fixed alarm status spacing.

Options
    • -1
    • +1
    /denali.pro.user
    • -36
    • +36
    /sources/model/malarmstatus.cpp
    • -2
    • +4
    /unittests/tst_messaging.cpp
    • -1
    • +1
    /unittests/tst_messaging.h
    • -0
    • +15
    /unittests/tst_models.cpp
    • -0
    • +2
    /unittests/tst_models.h
12:09 pm

Peter Lucia <plucia@diality.com>

Improved code coverage to 99.967%

Options
    • -4
    • +4
    /denali.pro.user
    • -0
    • +2
    /sources/canbus/messagedispatcher.cpp
    • -0
    • +2
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +0
    /sources/gui/guiview.h
    • -0
    • +2
    /sources/view/valarmstatus.cpp
    • -3
    • +1
    /sources/view/valarmstatus.h
    • -0
    • +42
    /unittests/tst_messaging.cpp
    • -0
    • +2
    /unittests/tst_messaging.h
Friday 26 Jun 2020
2:03 pm

Peter Lucia <plucia@diality.com>

Changed -q flag to disable hd communication timeout only, squishqt, code coverage changes

Options
    • -5
    • +5
    /main.cpp
    • -1
    • +2
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -1
    • +1
    /sources/main.h
    • -3
    • +4
    /sources/view/valarmstatus.cpp
    • -0
    • +4
    /sources/view/valarmstatus.h
Thursday 25 Jun 2020
5:55 pm

Peter Lucia <plucia@diality.com>

Updates to support unit testing

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /denali.qrc
    • -0
    • +7
    /main.cpp
    • -83
    • +0
    /sources/gui/qml/components/NotificationBar2.qml
    • -0
    • +83
    /sources/gui/qml/components/NotificationBarSmall.qml
    • -1
    • +1
    /sources/gui/qml/components/TouchArea.qml
    • -0
    • +1
    /sources/gui/qml/main.qml
    • -2
    • +5
    /sources/gui/qml/pages/SettingsHome.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentBase.qml
    • -0
    • +1
    /sources/main.h
    • -0
    • +5
    /sources/view/valarmstatus.cpp
9:44 am

Peter Lucia <plucia@diality.com>

Updated alarm ID an messages

Options
    • -52
    • +61
    /sources/model/malarmstatus.cpp
9:22 am

Peter Lucia <plucia@diality.com>

Merged master into UI Alarms.

Options
    • -2
    • +33
    /denali.pro
    • -106
    • +270
    /denali.pro.user
    • -1
    • +18
    /denali.qrc
    • -18
    • +33
    /main.cpp
    • -34
    • +2
    /sources/applicationcontroller.cpp
    • -8
    • +9
    /sources/applicationcontroller.h
    • -4
    • +80
    /sources/canbus/messagedispatcher.cpp
    • -4
    • +10
    /sources/canbus/messagedispatcher.h
    • -0
    • +15
    /sources/canbus/messageglobals.h
    • -20
    • +225
    /sources/canbus/messageinterpreter.cpp
    • -10
    • +2
    /sources/gui/guicontroller.cpp
    • -13
    • +3
    /sources/gui/guicontroller.h
    • -1
    • +18
    /sources/gui/guiglobals.h
    • -13
    • +0
    /sources/gui/guiview.h
    • -1
    • +6
    /sources/gui/qml/components/ModalDialog.qml
  16. … 11 more files in changeset.
Tuesday 23 Jun 2020
5:55 pm

Behrouz NematiPour

Merge branch 'DEN-3149_TreatmentUltrafiltrationAdjustment'

Options
5:18 pm

Behrouz NematiPour

DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h
    • -1
    • +1
    /unittests/tst_canbus.cpp
    • -3
    • +0
    /unittests/tst_messaging.h
    • -8
    • +8
    /unittests/tst_models.cpp
    • -2
    • +2
    /unittests/tst_views.cpp
2:18 pm

Behrouz NematiPour

DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -1
    • +1
    /sources/model/mtreatmentadjustrequests.h
    • -12
    • +6
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp
    • -0
    • +31
    /unittests/tst_views.cpp
    • -0
    • +2
    /unittests/tst_views.h
10:38 am

Peter Lucia <plucia@diality.com>

Added spaces

Options
    • -1
    • +3
    /sources/canbus/messageinterpreter.cpp
10:27 am

Peter Lucia <plucia@diality.com>

Removed unused import, renamed pressed to click

Options
    • -4
    • +4
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -2
    • +2
    /sources/gui/qml/main.qml
    • -1
    • +0
    /sources/gui/qml/pages/SettingsHome.qml
9:23 am

Peter Lucia <plucia@diality.com>

Updated valarmstatus.cpp

Options
    • -5
    • +3
    /sources/view/valarmstatus.cpp
8:56 am

Peter Lucia <plucia@diality.com>

Removed ColorOverlay and QGraphicalEffects

Options
    • -1
    • +1
    /resources/images/bell-off.svg
    • -1
    • +1
    /resources/images/bell.svg
    • -21
    • +2
    /sources/gui/qml/components/NotificationBar.qml
    • -10
    • +0
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -0
    • +1
    /sources/gui/qml/globals/Variables.qml
Monday 22 Jun 2020
9:13 pm

Behrouz NematiPour

DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -5
    • +5
    /denali.pro.user
    • -2
    • +2
    /sources/canbus/frameinterface.cpp
    • -7
    • +7
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +2
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +7
    /sources/model/mloadcellreadings.h
    • -0
    • +7
    /sources/model/mtemperaturesensors.h
    • -1
    • +1
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h
    • -3
    • +7
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp
    • -0
    • +10
    /unittests/tst_canbus.cpp
    • -0
    • +2
    /unittests/tst_canbus.h
    • -1
    • +26
    /unittests/tst_messaging.cpp
    • -1
    • +4
    /unittests/tst_messaging.h
    • -5
    • +312
    /unittests/tst_models.cpp
    • -0
    • +16
    /unittests/tst_models.h
2:12 pm

Peter Lucia <plucia@diality.com>

Fixed z order of mouse area

Options
    • -6
    • +6
    /sources/gui/qml/components/NotificationBar.qml
12:44 pm

Behrouz NematiPour

DEN-3157 : Code Coverage

- DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -2
    • +0
    /sources/gui/qml/components/UltrafiltrationButton.qml
    • -0
    • +222
    /unittests/tst_messaging.cpp
    • -1
    • +28
    /unittests/tst_messaging.h
    • -3
    • +3
    /unittests/tst_models.cpp
    • -1
    • +0
    /unittests/tst_models.h
11:04 am

Peter Lucia <plucia@diality.com>

Using message globals in applicationcontroller.h, moved guicontroller.h import to .cpp

Options
    • -0
    • +1
    /sources/applicationcontroller.cpp
    • -1
    • +1
    /sources/applicationcontroller.h
8:52 am

Peter Lucia <plucia@diality.com>

Moved #includes to cpp files.

Options
    • -0
    • +5
    /sources/applicationcontroller.cpp
    • -5
    • +0
    /sources/applicationcontroller.h
8:46 am

Peter Lucia <plucia@diality.com>

Address code review comments

Options
    • -2
    • +2
    /sources/gui/guiglobals.h
    • -59
    • +56
    /sources/gui/qml/components/NotificationBar.qml
    • -0
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    /sources/gui/qml/main.qml