hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
HD-DENBUG-328_Venous Pressure Alarm Did Not Trigger When Pressure Dropped TO 0 Mmhg Stagi
HD-DENBUG-328_Venous Pressure Alarm Did Not Trigger When Pressure Dropped TO 0 Mmhg Stagi
HD-DENBUG-328_Venous Pressure Alarm Did Not Trigger When Pressure Dropped TO 0 Mmhg Staging
HD-DENBUG-328_Venous Pressure Alarm Did Not Trigger When Pressure Dropped TO 0 Mmhg Staging
RESOLVED IN CODEWALKTHROUGH

RESOLVED IN CODEWALKTHROUGH

DENBUG-328 addressed the code review comments

Done

Done

Please add the comments mentioning the reason/purpose for the checking fluid level timeout alarm?

Please add the comments mentioning the reason/purpose for the checking fluid level timeout alarm?

DENBUG-328 updated the VectorCAST test cases

DENBUG-328 updated the UI institutional record structure

DENBUG-328 updated the min venous wide window range code

    • -4
    • +5
    /firmware/App/Modes/ModeTreatmentParams.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.h
DENBUG-328 updated the air trap upper level fluid detection code

DENBUG-328 added persistent alarm for the air trap upper level fluid detection

    • -1
    • +23
    /firmware/App/Controllers/AirTrap.c
DENBUG-328 added min venous limit from the institutional record

    • -0
    • +16
    /firmware/App/Modes/ModeTreatmentParams.c
    • -0
    • +1
    /firmware/App/Modes/ModeTreatmentParams.h
HD-DENBUG-328_Venous Pressure Alarm Did Not Trigger When Pressure Dropped TO 0 Mmhg Staging
HD-DENBUG-328_Venous Pressure Alarm Did Not Trigger When Pressure Dropped TO 0 Mmhg Staging
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

How is this if different than the else above? I don't think we need a separate if/else for not detected debounce - everything can be done in the if/else above.

How is this if different than the else above? I don't think we need a separate if/else for not detected debounce - everything can be done in the if/else above.

These should be initialized to zero in init function.

These should be initialized to zero in init function.

We are only debouncing the transition from detected to not detected (syringe removal). Is that our design intent?

We are only debouncing the transition from detected to not detected (syringe removal). Is that our design intent?

HD-DENBUG-326_Syringe Switch Detection Failure Staging
HD-DENBUG-326_Syringe Switch Detection Failure Staging