td-firmware / firmware / App / Controllers

AirPump.c

Clone Tools

Stats

Commits this week: 16
Total Committers: 6
Last Commit: 02 Mar
Commits this week: 16

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 02 Mar
8:46 pm

Sean Nash

11:54 am

Vendor - TEL - Sameer Poyil

fixed in latest code

fixed in latest code

11:53 am

Vendor - TEL - Sameer Poyil

implemented

implemented

11:53 am

Vendor - TEL - Sameer Poyil

fixed

fixed

9:53 am

Sean Nash

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

9:51 am

Sean Nash

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

7:42 am

Vendor - TEL - Sameer Poyil

Fixed

Fixed

7:37 am

Vendor - TEL - Sameer Poyil

removed from here

removed from here

7:36 am

Vendor - TEL - Sameer Poyil

fixed

fixed

Friday 27 Feb
2:56 pm

Vendor - TEL - Sameer Poyil

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

1:32 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:32 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:30 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:30 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:29 pm

Sean Nash

I think alarm should be handled inside the setAirPumpState() function.

I think alarm should be handled inside the setAirPumpState() function.

1:29 pm

Sean Nash

Should we have alarm here?

Should we have alarm here?

1:28 pm

Sean Nash

duty misspelled.

duty misspelled.

1:26 pm

Sean Nash

Can we remove inclusion of fpga here? It shouldn't be needed.

Can we remove inclusion of fpga here? It shouldn't be needed.

10:04 am

Vendor - TEL - Jashwant Gantyada

9:17 am

Vendor - TEL - Sameer Poyil

pushed new code

pushed new code

9:14 am

Vendor - TEL - Sameer Poyil

Fixed

Fixed

9:14 am

Vendor - TEL - Sameer Poyil

fixed it in commit ID 71a6797

fixed it in commit ID 71a6797

Thursday 26 Feb
10:52 pm

Sean Nash

I don't like controller bypassing driver to get to fpga access functions. There should be a get function in the driver that we can call here instead.

I don't like controller bypassing driver to get to fpga access functions. There should be a get function in the driver that we can call here instead.

10:51 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

10:49 pm

Sean Nash

Why two leading zeroes?

Why two leading zeroes?

10:02 am

Vendor - TEL - Sameer Poyil

Ya agreed. for the time being keeping it , we can later remove it after feature development complete

Ya agreed. for the time being keeping it , we can later remove it after feature development complete