td-firmware / firmware / App / Services

FpgaTD.h

Clone Tools

Stats

Commits this week: 4
Total Committers: 6
Last Commit: 02 Mar
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 02 Mar
8:46 pm

Sean Nash

4:16 pm

Sean Nash

2:13 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:58 pm

Sean Nash

Update I/O section here to include rotor revs accumulated and previous.

Update I/O section here to include rotor revs accumulated and previous.

1:32 pm

Vendor - TEL - Jashwant Gantyada

handled accordingly.

handled accordingly.

1:32 pm

Vendor - TEL - Jashwant Gantyada

removed and added.

removed and added.

11:54 am

Vendor - TEL - Sameer Poyil

fixed in latest code

fixed in latest code

11:53 am

Vendor - TEL - Sameer Poyil

implemented

implemented

11:53 am

Vendor - TEL - Sameer Poyil

fixed

fixed

11:16 am

Sean Nash

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

10:42 am

Sean Nash

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

9:53 am

Sean Nash

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

9:51 am

Sean Nash

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

9:02 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation
7:42 am

Vendor - TEL - Sameer Poyil

Fixed

Fixed

7:37 am

Vendor - TEL - Sameer Poyil

removed from here

removed from here

7:36 am

Vendor - TEL - Sameer Poyil

fixed

fixed

Friday 27 Feb
2:56 pm

Vendor - TEL - Sameer Poyil

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

1:32 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:32 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:30 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:30 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:29 pm

Sean Nash

I think alarm should be handled inside the setAirPumpState() function.

I think alarm should be handled inside the setAirPumpState() function.

1:29 pm

Sean Nash

Should we have alarm here?

Should we have alarm here?

1:28 pm

Sean Nash

duty misspelled.

duty misspelled.

1:26 pm

Sean Nash

Can we remove inclusion of fpga here? It shouldn't be needed.

Can we remove inclusion of fpga here? It shouldn't be needed.