ro-firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 28 Aug
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 02 Sep
10:56 am

Raghu Kallala

LDT-1928 latest from staging

Options
Thursday 28 Aug
1:40 pm

Raghu Kallala

Updated ToDo check for inletpressurecheck init call

Options
    • -1
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
Wednesday 27 Aug
8:16 am

Raghu Kallala

Addressed review comment to remove flag assignment in paused state.

Options
    • -1
    • +0
    /firmware/App/Modes/InletPressureCheck.c
Friday 22 Aug
3:21 pm

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/FPCommon.h
3:05 pm

Michael Garthwaite

Merge branch 'LDT-828-stop-state-fp' into staging

Options
Wednesday 20 Aug
8:21 am

Michael Garthwaite

LDT-828: fixed pressure sensor conversions for alpha units

Options
    • -7
    • +8
    /firmware/App/Drivers/PressureSensor.c
6:31 am

Raghu Kallala

Addressed review comments.

Options
    • -7
    • +7
    /firmware/App/Modes/InletPressureCheck.c
    • -4
    • +5
    /firmware/App/Modes/InletPressureCheck.h
    • -0
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
    • -2
    • +0
    /firmware/source/sys_main.c
Tuesday 19 Aug
10:24 am

Raghu Kallala

Addressed review comments to remove unwanted code lines and handled state assignment.

Options
    • -4
    • +1
    /firmware/App/Modes/InletPressureCheck.c
    • -1
    • +0
    /firmware/App/Modes/InletPressureCheck.h
    • -0
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
Wednesday 13 Aug
7:58 am

Raghu Kallala

Implemented Inlet Pressure check functionality with Boost Pump

Options
    • -0
    • +371
    /firmware/App/Modes/InletPressureCheck.c
    • -0
    • +53
    /firmware/App/Modes/InletPressureCheck.h
    • -1
    • +6
    /firmware/App/Modes/ModePreGenPermeate.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -1
    • +3
    /firmware/App/Services/Messaging.c
    • -0
    • +2
    /firmware/source/sys_main.c
Wednesday 06 Aug
8:24 am

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/FPCommon.h
Tuesday 05 Aug
1:06 pm

Michael Garthwaite

Merge branch 'LDT-566-water-treatment-and-degassing-fp-2' into staging

Options
Monday 04 Aug
9:26 am

Michael Garthwaite

LDT-566: code review comments.

Options
    • -2
    • +0
    /firmware/App/Controllers/PermeateTank.c
    • -1
    • +0
    /firmware/App/Services/DDInterface.c
    • -1
    • +1
    /firmware/App/Services/Messaging.c
Friday 01 Aug
3:56 pm

Michael Garthwaite

LDT-566: code review comments

Options
    • -8
    • +7
    /firmware/App/Controllers/PermeateTank.c
    • -3
    • +0
    /firmware/App/Controllers/ROPump.c
    • -1
    • +0
    /firmware/App/Modes/FPModeStandby.c
    • -2
    • +0
    /firmware/App/Modes/FlushConcentrate.c
    • -1
    • +0
    /firmware/App/Modes/ModePreGenPermeate.c
    • -1
    • +0
    /firmware/App/Modes/ModePreGenPermeateDefeatured.h
    • -1
    • +0
    /firmware/App/Monitors/Pressure.c
    • -4
    • +0
    /firmware/App/Monitors/Temperature.c
    • -1
    • +0
    /firmware/App/Services/AlarmMgmtFP.h
    • -6
    • +0
    /firmware/App/Services/DDInterface.c
    • -1
    • +1
    /firmware/App/Services/DDInterface.h
    • -1
    • +0
    /firmware/App/Services/FpgaFP.c
    • -4
    • +3
    /firmware/App/Services/Messaging.c
    • -1
    • +0
    /firmware/App/Services/SystemCommFP.c
12:22 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -1
    • +1
    /firmware/App/Drivers/ConductivitySensor.c
    • -2
    • +4
    /firmware/App/Modes/ModeGenPermeateDefeatured.c
    • -7
    • +6
    /firmware/App/Modes/ModeGenPermeateDefeatured.h
    • -4
    • +8
    /firmware/App/Modes/ModePreGenPermeateDefeatured.c
    • -6
    • +6
    /firmware/App/Modes/ModePreGenPermeateDefeatured.h
    • -2
    • +0
    /firmware/source/sys_main.c
12:08 pm

Michael Garthwaite

LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

Options
    • -1
    • +3
    /firmware/App/Controllers/BoostPump.c
    • -4
    • +6
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Drivers/ConductivitySensor.c
    • -3
    • +3
    /firmware/App/Drivers/PressureSensor.c
    • -0
    • +1
    /firmware/App/Modes/FlushConcentrate.c
    • -0
    • +0
    /firmware/App/Modes/PressureCheck.c
    • -15
    • +0
    /firmware/App/Modes/PressureCheck.h
    • -5
    • +0
    /firmware/App/Monitors/WaterQualityMonitor.c
Thursday 31 Jul
11:51 am

Michael Garthwaite

LDT-566: fixed macro calls

Options
    • -4
    • +4
    /firmware/App/Controllers/ROPump.c
11:49 am

Michael Garthwaite

LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

Options
    • -3
    • +3
    /firmware/App/Controllers/BoostPump.c
    • -1
    • +1
    /firmware/App/Controllers/PermeateTank.c
    • -7
    • +7
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Drivers/FluidPump.h
    • -1
    • +1
    /firmware/App/Modes/FlushPermeate.c
    • -4
    • +5
    /firmware/source/sys_main.c
Wednesday 30 Jul
1:30 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -11
    • +5
    /firmware/App/Controllers/BoostPump.c
    • -650
    • +0
    /firmware/App/Controllers/Heaters.c
    • -60
    • +0
    /firmware/App/Controllers/Heaters.h
    • -18
    • +20
    /firmware/App/Controllers/ROPump.c
    • -3
    • +0
    /firmware/App/Controllers/ROPump.h
    • -399
    • +0
    /firmware/App/Drivers/TemperatureSensor.c
    • -59
    • +0
    /firmware/App/Drivers/TemperatureSensor.h
    • -1
    • +1
    /firmware/App/Modes/FPModeStandby.c
    • -19
    • +24
    /firmware/App/Modes/FlushConcentrate.c
    • -2
    • +1
    /firmware/App/Modes/FlushConcentrate.h
    • -10
    • +11
    /firmware/App/Modes/FlushFilter.c
    • -9
    • +13
    /firmware/App/Modes/FlushPermeate.c
    • -30
    • +13
    /firmware/App/Modes/ModeGenPermeate.c
    • -9
    • +4
    /firmware/App/Modes/ModeGenPermeate.h
    • -1
    • +0
    /firmware/App/Monitors/Conductivity.c
  16. … 5 more files in changeset.
11:24 am

Michael Garthwaite

LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

Options
    • -5
    • +350
    /firmware/App/Controllers/PermeateTank.c
    • -7
    • +10
    /firmware/App/Controllers/PermeateTank.h
    • -9
    • +7
    /firmware/App/Modes/FPModeFault.c
    • -5
    • +6
    /firmware/App/Modes/FlushConcentrate.c
    • -6
    • +5
    /firmware/App/Modes/FlushFilter.c
    • -7
    • +8
    /firmware/App/Modes/FlushPermeate.c
    • -123
    • +11
    /firmware/App/Modes/ModeGenPermeate.c
    • -4
    • +4
    /firmware/App/Modes/ModeGenPermeateDefeatured.c
    • -24
    • +25
    /firmware/App/Modes/ModePreGenPermeate.c
    • -12
    • +12
    /firmware/App/Modes/ModePreGenPermeateDefeatured.c
    • -1
    • +66
    /firmware/App/Monitors/Temperature.c
    • -0
    • +20
    /firmware/App/Monitors/Temperature.h
    • -76
    • +0
    /firmware/App/Monitors/WaterQualityMonitor.c
    • -19
    • +0
    /firmware/App/Monitors/WaterQualityMonitor.h
    • -18
    • +26
    /firmware/App/Services/AlarmMgmtFP.c
  16. … 6 more files in changeset.
Tuesday 29 Jul
3:54 pm

Michael Garthwaite

LDT-566: fixed messaging ACK

Options
    • -4
    • +4
    /firmware/App/Services/Messaging.c
1:05 pm

Michael Garthwaite

LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

Options
    • -1
    • +1
    /firmware/App/Controllers/PermeateTank.c
    • -19
    • +245
    /firmware/App/Modes/FPModeFault.c
    • -1
    • +1
    /firmware/App/Modes/FPModeFault.h
    • -3
    • +0
    /firmware/App/Modes/FlushConcentrate.c
    • -2
    • +0
    /firmware/App/Modes/FlushFilter.c
    • -3
    • +0
    /firmware/App/Modes/FlushPermeate.c
    • -5
    • +5
    /firmware/App/Modes/ModeGenPermeate.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmtFP.c
12:15 pm

Michael Garthwaite

LDT-566: FP Safety shutdown override. fixed includes.

Options
    • -0
    • +52
    /firmware/App/Controllers/PermeateTank.c
    • -0
    • +65
    /firmware/App/Controllers/PermeateTank.h
    • -3
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Drivers/PAL.c
    • -1
    • +1
    /firmware/App/Drivers/PAL.h
    • -39
    • +22
    /firmware/App/Drivers/SafetyShutdown.c
    • -2
    • +1
    /firmware/App/Drivers/SafetyShutdown.h
    • -0
    • +1
    /firmware/App/Modes/FPModeFault.c
    • -3
    • +6
    /firmware/App/Modes/FPModeFault.h
    • -2
    • +2
    /firmware/App/Modes/FPModeInitPOST.h
    • -2
    • +2
    /firmware/App/Modes/FPModeStandby.h
    • -2
    • +2
    /firmware/App/Modes/FPOperationModes.h
    • -1
    • +3
    /firmware/App/Services/Messaging.c
10:06 am

Michael Garthwaite

WIP on develop

LDT-566: develop fixes

Options
    • -1
    • +1
    /firmware/App/Modes/FlushConcentrate.c
    • -1
    • +1
    /firmware/App/Modes/FlushFilter.c
    • -1
    • +1
    /firmware/App/Modes/FlushPermeate.c
    • -1
    • +1
    /firmware/App/Modes/ModeGenPermeateDefeatured.c
    • -5
    • +5
    /firmware/App/Modes/ModePreGenPermeate.c
    • -3
    • +3
    /firmware/App/Modes/ModePreGenPermeateDefeatured.c
9:58 am

Michael Garthwaite

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

Options
    • -1
    • +2
    /firmware/App/Controllers/BoostPump.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +2
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Drivers/ConductivitySensor.c
    • -12
    • +11
    /firmware/App/Drivers/PressureSensor.c
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensor.c
    • -0
    • +88
    /firmware/App/Modes/FPModeFault.c
    • -0
    • +40
    /firmware/App/Modes/FPModeFault.h
    • -0
    • +66
    /firmware/App/Modes/FPModeInitPOST.c
    • -0
    • +44
    /firmware/App/Modes/FPModeInitPOST.h
    • -0
    • +149
    /firmware/App/Modes/FPModeStandby.c
    • -0
    • +47
    /firmware/App/Modes/FPModeStandby.h
    • -0
    • +475
    /firmware/App/Modes/FPOperationModes.c
    • -0
    • +62
    /firmware/App/Modes/FPOperationModes.h
    • -1
    • +2
    /firmware/App/Modes/FlushConcentrate.c
  16. … 25 more files in changeset.
Friday 25 Jul
1:12 pm

Michael Garthwaite

LDT-566: fixed valve order

Options
    • -3
    • +3
    /firmware/App/Controllers/Valves.h
1:09 pm

Michael Garthwaite

LDT-566: fixed valve ordering

Options
    • -2
    • +2
    /firmware/App/Controllers/Valves.h
9:18 am

Michael Garthwaite

Revert "LDT-566: permeate tank file creation"

This reverts commit 6e65344e6675394118806ce98dc428c27920e1cb.

Options
    • -428
    • +0
    /firmware/App/Controllers/PermeateTank.c
    • -60
    • +0
    /firmware/App/Controllers/PermeateTank.h
9:16 am

Michael Garthwaite

LDT-566: permeate tank file creation

Options
    • -0
    • +428
    /firmware/App/Controllers/PermeateTank.c
    • -0
    • +60
    /firmware/App/Controllers/PermeateTank.h
8:28 am

Michael Garthwaite

LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with latest HDD

Options
    • -1
    • +2
    /firmware/App/Controllers/Valves.c
    • -1
    • +4
    /firmware/App/Controllers/Valves.h
    • -0
    • +6
    /firmware/App/Modes/FlushConcentrate.c
    • -0
    • +6
    /firmware/App/Modes/FlushFilter.c
    • -0
    • +6
    /firmware/App/Modes/FlushPermeate.c
    • -1
    • +1
    /firmware/App/Modes/ModeFault.c
    • -0
    • +7
    /firmware/App/Modes/ModeGenPermeate.c
    • -0
    • +6
    /firmware/App/Modes/ModeGenPermeateDefeatured.c
    • -0
    • +3
    /firmware/App/Modes/ModePreGenPermeate.c
    • -0
    • +9
    /firmware/App/Modes/ModePreGenPermeateDefeatured.c
    • -0
    • +3
    /firmware/App/Modes/ModeStandby.c
    • -25
    • +125
    /firmware/App/Monitors/Conductivity.c
    • -0
    • +1
    /firmware/App/Monitors/Conductivity.h
    • -167
    • +2
    /firmware/App/Monitors/Pressure.c
    • -308
    • +2
    /firmware/App/Monitors/Temperature.c
  16. … 6 more files in changeset.
Tuesday 22 Jul
2:51 pm

Michael Garthwaite

WIP on develop

LDT-566: LDT-676: Removed M7 and P20 valves.

Options
    • -2
    • +0
    /firmware/App/Controllers/Valves.h
    • -2
    • +0
    /firmware/App/Modes/ModeFault.c
    • -2
    • +0
    /firmware/App/Modes/ModeGenPermeate.c
    • -2
    • +0
    /firmware/App/Modes/ModeStandby.c