td-firmware / firmware / App / Services / StateServices

TubeSetInstall.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 3
Last Commit: 31 Jul
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Jul
11:10 am

Vendor - TEL - Arpita Srivastava

While you are updating this file, can please break this line?

While you are updating this file, can please break this line?

11:08 am

Vendor - TEL - Arpita Srivastava

Can we align like this result = u32BroadcastIntervalOverride( message, &preTreatmentStatePublishInterval, TASK_GENERAL_INTERVAL );

Can we align like this
result = u32BroadcastIntervalOverride( message,
&preTreatmentStatePublishInterval,
TASK_GENERAL_INTERVAL );

11:07 am

Vendor - TEL - Arpita Srivastava

Add to inputs: preTreatmentStatePublishInterval

Add to inputs: preTreatmentStatePublishInterval

Thursday 30 Jul
2:50 pm

Vendor - TEL - Vijay Pamula

Updated to store the result in a local BOOL

Updated to store the result in a local BOOL

2:32 pm

Sean Nash

Set to local BOOL and then return the BOOL.

Set to local BOOL and then return the BOOL.

2:31 pm

Sean Nash

Make a #define up top for the 5.

Make a #define up top for the 5.

2:30 pm

Sean Nash

Initialize this in the init function instead of here.

Initialize this in the init function instead of here.

2:29 pm

Vendor - TEL - Vijay Pamula

Yes,I Added the Dial-in override function for the publish interval.

Yes,I Added the Dial-in override function for the publish interval.

10:43 am

Sean Nash

Are we going to allow Dialin to override this publish interval?

Are we going to allow Dialin to override this publish interval?

10:42 am

Sean Nash

Add a blank line before return statement.

Add a blank line before return statement.

10:41 am

Sean Nash

Try to initialize these broadcast timer counters to different values (between 0 and 19) so that we don't broadcast all data messages at the same time - we want to spread these broadcasts out over e...

Try to initialize these broadcast timer counters to different values (between 0 and 19) so that we don't broadcast all data messages at the same time - we want to spread these broadcasts out over each 1 second period of time.

10:31 am

Sean Nash

Set "Stops" property back to TRUE like the other reserved UI alarms.

Set "Stops" property back to TRUE like the other reserved UI alarms.

Tuesday 28 Jul
7:51 pm

Sean Nash

2:47 pm

Vendor - TEL - Arpita Srivastava

break this line

break this line

2:39 pm

Vendor - TEL - Arpita Srivastava

add an empty else block after the last else if block in these functions handlePreTxHeparinPreloadState handlePreTxHeparinAwaitSyringeLoadConfirmationState handlePreTxHeparinSeekState handlePreTxHep...

add an empty else block after the last else if block in these functions
handlePreTxHeparinPreloadState
handlePreTxHeparinAwaitSyringeLoadConfirmationState
handlePreTxHeparinSeekState
handlePreTxHeparinPrimeState
handlePreTxHeparinBolusState

2:32 pm

Vendor - TEL - Arpita Srivastava

break this line

break this line

10:44 am

Vendor - TEL - Arpita Srivastava

Add initialization for heparinSetupResumeRequested and syringeLoadConfirmed

Add initialization for heparinSetupResumeRequested and syringeLoadConfirmed

10:42 am

Vendor - TEL - Arpita Srivastava

Align all the function comments

Align all the function comments

10:19 am

Vendor - TEL - Arpita Srivastava

Delete this row.

Delete this row.

9:52 am

Vendor - TEL - Arpita Srivastava

should we replace current Pre-Treatment state with currentPreTreatmentState?

should we replace current Pre-Treatment state with currentPreTreatmentState?

9:51 am

Vendor - TEL - Arpita Srivastava

Add @Message

Add @Message

9:46 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

9:46 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

Monday 27 Jul
10:26 am

Sean Nash

Why is this on a separate line? Move after = above.

Why is this on a separate line? Move after = above.

10:22 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:22 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:01 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
Sunday 26 Jul
8:37 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?

Tuesday 21 Jul
5:45 pm

Sean Nash

I think ( setTxDur - preStop ) should be changed to ( preStop ). Also, I think preStop should be renamed to hepDurMin.

I think ( setTxDur - preStop ) should be changed to ( preStop ).
Also, I think preStop should be renamed to hepDurMin.

2:10 pm

Sean Nash

Can we remote this TODO comment?

Can we remote this TODO comment?