td-firmware / firmware / App / Services

SystemCommTD.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 09:16
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
14 hrs ago

Vendor - TEL - Arpita Srivastava

What is the use case of including this header?

What is the use case of including this header?

14 hrs ago

Vendor - TEL - Arpita Srivastava

What is the use case of including this header?

What is the use case of including this header?

14 hrs ago

Vendor - TEL - Arpita Srivastava

Should we move this up before the test functions?

Should we move this up before the test functions?

14 hrs ago

Vendor - TEL - Arpita Srivastava

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

14 hrs ago

Vendor - TEL - Arpita Srivastava

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT

14 hrs ago

Vendor - TEL - Arpita Srivastava

is the function description correct? change DG -> DD

is the function description correct?
change DG -> DD

14 hrs ago

Vendor - TEL - Arpita Srivastava

output is none

output is none

14 hrs ago

Vendor - TEL - Arpita Srivastava

add safetyShutdownSelfTestStatus to outputs

add safetyShutdownSelfTestStatus to outputs

14 hrs ago

Vendor - TEL - Arpita Srivastava

why is this line commented out? Should we remove it or add a TODO?

why is this line commented out? Should we remove it or add a TODO?

14 hrs ago

Vendor - TEL - Arpita Srivastava

Remove blank line

Remove blank line

14 hrs ago

Vendor - TEL - Arpita Srivastava

align comment

align comment

14 hrs ago

Vendor - TEL - Arpita Srivastava

break this line

break this line

14 hrs ago

Vendor - TEL - Arpita Srivastava

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

14 hrs ago

Vendor - TEL - Arpita Srivastava

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

14 hrs ago

Vendor - TEL - Arpita Srivastava

remove blank line

remove blank line

14 hrs ago

Vendor - TEL - Arpita Srivastava

Optional: should we rename these to dd and update the comment as well. dgPOSTPassed -> ddPOSTPassed dgPOSTResultReceived -> ddPOSTResultReceived dgVersion -> ddVersion

Optional: should we rename these to dd and update the comment as well.
dgPOSTPassed -> ddPOSTPassed
dgPOSTResultReceived -> ddPOSTResultReceived
dgVersion -> ddVersion

14 hrs ago

Vendor - TEL - Arpita Srivastava

add @alarms

add @alarms

14 hrs ago

Vendor - TEL - Arpita Srivastava

break line

break line

14 hrs ago

Vendor - TEL - Arpita Srivastava

add @alarms

add @alarms

14 hrs ago

Vendor - TEL - Arpita Srivastava

Should we use the test config TEST_CONFIG_DISABLE_ALARM_AUDIO?

Should we use the test config TEST_CONFIG_DISABLE_ALARM_AUDIO?

Thursday 30 Jul
5:07 pm

Vendor - TEL - Arpita Srivastava

align comments

align comments

5:02 pm

Vendor - TEL - Arpita Srivastava

All the else if should always have an ending else block. add a blank else block or change line 232 as else { if() { } }

All the else if should always have an ending else block.

add a blank else block or change line 232 as
else
{
if() { }
}

4:58 pm

Vendor - TEL - Arpita Srivastava

Add @alarms

Add @alarms

Wednesday 29 Jul
1:22 pm

Sean Nash

10:55 am

Vendor - TEL - Suresh Dharnala

Fixed.

Fixed.

10:54 am

Vendor - TEL - Suresh Dharnala

Moved.

Moved.

10:53 am

Sean Nash

Move buttons down just above "Comm.h". And why is buttons being included here?

Move buttons down just above "Comm.h". And why is buttons being included here?

10:53 am

Vendor - TEL - Suresh Dharnala

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

10:50 am

Sean Nash

I don't see it.

I don't see it.

10:50 am

Sean Nash

I don't see it.

I don't see it.