firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
updated.

updated.

done.

done.

updated.

updated.

updated.

updated.

removed and used default value as they are the same.

removed and used default value as they are the same.

yes. updated.

yes. updated.

updated and used as suggested.

updated and used as suggested.

noted.

noted.

We have a reset function above that does this. Should we call it?

We have a reset function above that does this. Should we call it?

Are we filtering at zero set rate? I guess we should, so then the duration would be 1 sec then?

Are we filtering at zero set rate? I guess we should, so then the duration would be 1 sec then?

I think minimum samples would be for max rate (500 mL/min), so 3 secs at 20 Hz = 60 samples.

I think minimum samples would be for max rate (500 mL/min), so 3 secs at 20 Hz = 60 samples.

PRODUCT should probably come before FILTER_SAMPLES above so that it can be used in that definition. Show derivation again. i.e. (500 * 3) indicating we want 3 seconds of filter duration for 500 mL/...

PRODUCT should probably come before FILTER_SAMPLES above so that it can be used in that definition.
Show derivation again. i.e. (500 * 3) indicating we want 3 seconds of filter duration for 500 mL/min rate and duration grows as rate is reduced.

600 will take a lot of memory (600 x 4 bytes = 2.4K). Ok for now, but if memory gets scarce, we will have to consider sampling less frequently to reduce the size of the moving average array. Also,...

600 will take a lot of memory (600 x 4 bytes = 2.4K). Ok for now, but if memory gets scarce, we will have to consider sampling less frequently to reduce the size of the moving average array.

Also, show derivation of this number so it's clear what it means and how we got to 600.
i.e. ((PRODUCT / 50) * (MS_PER_SECOND / TASK_GENERAL_INTERVAL)) indicating how many samples we need to buffer for worst case which is lowest flow rate (50) requiring max duration (30 sec) at 20 Hz sample rate.

We typically refer to set blood flow rate as Qb.

We typically refer to set blood flow rate as Qb.

Refactor this function to have only one return statement.

Refactor this function to have only one return statement.

You could just do a memset() here.

You could just do a memset() here.

Need unique s/w malf id.

Need unique s/w malf id.

Is this right?

Is this right?

Align =

Align =

Should be in Ejector.c

Should be in Ejector.c

Move it right after init function.

Move it right after init function.

Remove Latch from name. No latch in Leahi.

Remove Latch from name. No latch in Leahi.

Should this be done in transition function?

Should this be done in transition function?

Add to .h file.

Add to .h file.

Don't need reason. Need modality.

Don't need reason. Need modality.

Alphabetize

Alphabetize

Should be RESPONSE msg, not request.

Should be RESPONSE msg, not request.

Do we need this?

Do we need this?

Both of these should be alarms. No need to respond to UI's response. Remove.

Both of these should be alarms. No need to respond to UI's response. Remove.

Not a Dialin msg. Renumber (no x8)

Not a Dialin msg. Renumber (no x8)