leahi-fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Put this stuff in transition function for this state. Remove venousSetupStateEntered flag.

Put this stuff in transition function for this state. Remove venousSetupStateEntered flag.

change flag to tubeSetLeakChecksStarted

change flag to tubeSetLeakChecksStarted

Shouldn't this be the pressure sensor normal setup state?

Shouldn't this be the pressure sensor normal setup state?

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

Call your transition function for new state here.

Call your transition function for new state here.

state removed.

state removed.

Don't need this flag or this if statement.

Don't need this flag or this if statement.

Think about including data.

Think about including data.

Needed?

Needed?

Still need cmd to barcode reader to scan.

Still need cmd to barcode reader to scan.

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

remove if statement. No occlusion sensor

remove if statement. No occlusion sensor

DrySelfTests

DrySelfTests

move to a private publish function.

move to a private publish function.

dry self-tests

dry self-tests

barcode scan request is made by TD to h/w via fpga. So not needed.

barcode scan request is made by TD to h/w via fpga. So not needed.

Remove this flag.

Remove this flag.

Remove this code.

Remove this code.

Remove this condition to apply the speed for BC switch only as well.

Remove this condition to apply the speed for BC switch only as well.

Check the else portion and do the required changes.

Check the else portion and do the required changes.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

Uncommented

Uncommented

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

Remove extra blank line.

Remove extra blank line.