td-firmware / firmware / App / Drivers

GLXferPump.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 13 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Mar
9:12 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

Tuesday 17 Mar
9:46 pm

Sean Nash

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

9:44 pm

Sean Nash

I was thinking that comment should go above the first if statement.

I was thinking that comment should go above the first if statement.

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:56 pm

Sean Nash

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below: #define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall con...

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

2:56 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:53 pm

Sean Nash

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:50 pm

Sean Nash

Should probably initialize your new stall counter variable.

Should probably initialize your new stall counter variable.

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

Sean Nash I need your help for writing this Alarm properties.

Sean Nash I need your help for writing this Alarm properties.

2:03 pm

Sean Nash

Wednesday 04 Mar
8:22 pm

Vendor - TEL - Sameer Poyil

Monday 02 Mar
8:46 pm

Sean Nash

11:54 am

Vendor - TEL - Sameer Poyil

fixed in latest code

fixed in latest code

11:53 am

Vendor - TEL - Sameer Poyil

implemented

implemented

11:53 am

Vendor - TEL - Sameer Poyil

fixed

fixed

9:53 am

Sean Nash

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

9:51 am

Sean Nash

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

7:42 am

Vendor - TEL - Sameer Poyil

Fixed

Fixed

7:37 am

Vendor - TEL - Sameer Poyil

removed from here

removed from here

7:36 am

Vendor - TEL - Sameer Poyil

fixed

fixed

Friday 27 Feb
2:56 pm

Vendor - TEL - Sameer Poyil

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

1:32 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:32 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:31 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

1:30 pm

Sean Nash

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().