Activity td-firmware/firmware/App/Monitors

Tree
Accordion

Stats

Commits this week: 6

Total Committers:	7
Last Commit:	13 Mar
Commits this week:	6

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 19 Mar

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

Tuesday 17 Mar

9:46 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

9:44 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
replied to Vendor - TEL - Varshini Nagabooshanam

I was thinking that comment should go above the first if statement.

I was thinking that comment should go above the first if statement.

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:56 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below: #define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall con...

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

2:56 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:53 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:50 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Should probably initialize your new stall counter variable.

Should probably initialize your new stall counter variable.

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Sean Nash I need your help for writing this Alarm properties.

Sean Nash I need your help for writing this Alarm properties.

2:03 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-3215-1
resumed reviewing

Friday 13 Mar

4:43 pm

Dara Navaei

More
1e5bc8d
changed 2 files
LDT-2240-disposable-tube-set-self-test, LDT-3126-blood-prime-td-updates and 2 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Bubbles.c
- History
- Source
- Diff
./Bubbles.c
… 1 more file in changeset.

3:23 pm

Dara Navaei

More
b017f10
changed 2 files
LDT-2240-disposable-tube-set-self-test, LDT-3126-blood-prime-td-updates and 3 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -1
- +1
./Pressures.h
- History
- Source
- Diff
./Pressures.h

3:21 pm

Vendor - TEL - Praneeth Bunne

3:04 pm

Vendor - TEL - Varshini Nagabooshanam

More
9f3f6f6
changed 2 files
LDT-1840-Transmembrane-Pressure-update, LDT-2240-disposable-tube-set-self-test and 4 more

Merge branch 'staging' into LDT-1840-Transmembrane-Pressure-update

- -1
- +35
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -1
- +3
./Pressures.h
- History
- Source
- Diff
./Pressures.h

2:59 pm

Vendor - TEL - Varshini Nagabooshanam

2:58 pm

Zoltan Miskolci and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-1840-1
finished reviewing

2:52 pm

Vendor - TEL - Praneeth Bunne

More
2ecbfd1
changed 1 file
LDT-2240-disposable-tube-set-self-test, LDT-3126-blood-prime-td-updates and 2 more

Merge branch 'LDT-3600-request-for-td-test-config-for' into staging

- -1
- +6
./Bubbles.c
- History
- Source
- Diff
./Bubbles.c

2:47 pm

Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-3600-1
finished reviewing

2:39 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

2:39 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:38 pm

Vendor - TEL - Varshini Nagabooshanam

More
62c699b
changed 2 files
LDT-1840-Transmembrane-Pressure-update, LDT-2240-disposable-tube-set-self-test and 4 more LEAHI-TD-FIRMWARE-LDT-1840-1

LDT-1840-Transmembrane-Pressure-update

- -1
- +0
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -0
- +2
./Pressures.h
- History
- Source
- Diff
./Pressures.h

2:26 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1840-1
replied to Vendor - TEL - Varshini Nagabooshanam

Still not packed.

Still not packed.

2:25 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1840-1
commented on review

Remove extra blank line.

Remove extra blank line.

2:23 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-3600-1
added Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

2:19 pm

Vendor - TEL - Varshini Nagabooshanam

Sure

Sure

1:45 pm

Vinayakam Mani

More
Re: LEAHI-TD-FIRMWARE-LDT-3600-1
commented on review

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

11:43 am

Dara Navaei

More
dccadda
changed 1 file
LDT-2240-disposable-tube-set-self-test, LDT-3126-blood-prime-td-updates and 3 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Bubbles.c
- History
- Source
- Diff
./Bubbles.c

11:30 am

Vendor - TEL - Varshini Nagabooshanam

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-20 01:00 -0700