td-firmware / firmware / App / Monitors

Bubbles.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 6
Last Commit: 13 Mar
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Mar
9:12 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

Tuesday 17 Mar
9:46 pm

Sean Nash

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

9:44 pm

Sean Nash

I was thinking that comment should go above the first if statement.

I was thinking that comment should go above the first if statement.

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:56 pm

Sean Nash

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below: #define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall con...

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

2:56 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:53 pm

Sean Nash

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:50 pm

Sean Nash

Should probably initialize your new stall counter variable.

Should probably initialize your new stall counter variable.

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

Sean Nash I need your help for writing this Alarm properties.

Sean Nash I need your help for writing this Alarm properties.

2:03 pm

Sean Nash

Friday 13 Mar
3:21 pm

Vendor - TEL - Praneeth Bunne

2:47 pm

Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash

2:23 pm

Sean Nash

1:45 pm

Vinayakam Mani

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

11:30 am

Vendor - TEL - Varshini Nagabooshanam

11:28 am

Dara Navaei

Wednesday 11 Mar
3:31 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
Friday 20 Feb
1:48 pm

Sean Nash

1:08 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

1:02 pm

Sean Nash

But now it's not in right position (in this table only). This table should be sorted by rank.

But now it's not in right position (in this table only). This table should be sorted by rank.

12:13 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:12 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

11:37 am

Sean Nash

This was correct before (assuming 711 was correct rank).

This was correct before (assuming 711 was correct rank).

11:36 am

Sean Nash

Why change rank back to 206? If priority is low, rank was probably correct at 711. I think you had correct properties before - it was just in the wrong row.

Why change rank back to 206? If priority is low, rank was probably correct at 711. I think you had correct properties before - it was just in the wrong row.

10:23 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:23 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Wednesday 18 Feb
9:45 pm

Sean Nash

This alarm does not belong here. Put it back where it was before. In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

This alarm does not belong here. Put it back where it was before.
In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

9:43 pm

Sean Nash

Why did you move it. The alarm is #30 so it should stay here where you had it before.

Why did you move it. The alarm is #30 so it should stay here where you had it before.