leahi-fwcommon

Clone Tools

Stats

Commits this week: 9
Total Committers: 13
Last Commit: 15 Sep 25
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 mins ago

Sean Nash

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

5 mins ago

Sean Nash

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above. What does nr stand for?

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

7 mins ago

Sean Nash

Let's remove this commented line.

Let's remove this commented line.

13 mins ago

Sean Nash

Add blank line before return.

Add blank line before return.

14 mins ago

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

16 mins ago

Sean Nash

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

17 mins ago

Sean Nash

Lower case x

Lower case x

19 mins ago

Sean Nash

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?

47 mins ago

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

52 mins ago

Sean Nash

1 hr ago

Sean Nash

3 hrs ago

Vendor - TEL - Sameer Poyil

I don't need to edit this file. I will check with Dara to exclude this file from code review.

I don't need to edit this file. I will check with Dara to exclude this file from code review.

3 hrs ago

Vendor - TEL - Sameer Poyil

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals. need to split it or need two message id.

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.

3 hrs ago

Vendor - TEL - Sameer Poyil

Its a problem . Vinay has to decide it

Its a problem . Vinay has to decide it

4 hrs ago

Michael Garthwaite

4 hrs ago

Vendor - TEL - Sameer Poyil and Sean Nash

5 hrs ago

Michael Garthwaite

per formatting for the test support function header. it is format used across many files

per formatting for the test support function header. it is format used across many files

5 hrs ago

Michael Garthwaite

fixed

fixed

5 hrs ago

Michael Garthwaite

fixed

fixed

5 hrs ago

Michael Garthwaite

fixed

fixed

5 hrs ago

Michael Garthwaite

fixed

fixed

5 hrs ago

Michael Garthwaite

fixed

fixed

5 hrs ago

Michael Garthwaite

fixed

fixed

5 hrs ago

Michael Garthwaite

fixed

fixed

5 hrs ago

Michael Garthwaite

fixed

fixed

5 hrs ago

Michael Garthwaite

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

Monday 13 Apr
2:58 pm

Vinayakam Mani

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

12:00 pm

Vinayakam Mani

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.