leahi-dialin / leahi_dialin / td / modules

valves.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 21 Oct
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 19 Dec
2:01 pm

Dara Navaei

1:53 pm

Michael Garthwaite , Zoltan Miskolci and Sean Nash

Thursday 18 Dec
5:28 pm

Zoltan Miskolci

Oh, ok, I thought 'i' only covers 8 bit not 32

Oh, ok, I thought 'i' only covers 8 bit not 32

5:27 pm

Dara Navaei

Integer 'i' is 4 bytes. Is that what you mean?

Integer 'i' is 4 bytes. Is that what you mean?

5:26 pm

Zoltan Miskolci

Aren't these fields are for 4 byte range? The integer is just 1 byte

Aren't these fields are for 4 byte range? The integer is just 1 byte

Tuesday 16 Dec
2:02 pm

Dara Navaei

LEAHI-DIALIN-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD
LEAHI-DIALIN-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD
Thursday 25 Sep
2:42 pm

jpaguio  (deleted user)

2:35 pm

Dara Navaei and Sean Nash

12:57 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2300: Resolved code review comments

Options
    • -1
    • +1
    ./valves.py
  2. … 40 more files in changeset.
12:16 pm

jpaguio  (deleted user)

Done - timestamps added to DD, FP, and TD

Done - timestamps added to DD, FP, and TD

12:13 pm

jpaguio  (deleted user)

Done

Done

12:12 pm

jpaguio  (deleted user)

Done

Done

12:11 pm

jpaguio  (deleted user)

Done

Done

Monday 22 Sep
2:26 pm

jpaguio  (deleted user)

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only...

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

9:48 am

Sean Nash

No timestamp?

No timestamp?

9:45 am

Sean Nash

I didn't see dbg variables in the publish list above.

I didn't see dbg variables in the publish list above.

9:44 am

Sean Nash

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere. Also, I think we typically list the timestamp ...

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

9:41 am

Sean Nash

Replace "dg" with "dd".

Replace "dg" with "dd".

9:38 am

Sean Nash

Replace "hd" with "dd".

Replace "hd" with "dd".

Monday 15 Sep
4:49 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2300: Added message ID to each observer

Options
    • -3
    • +3
    ./valves.py
  2. … 40 more files in changeset.
4:03 pm

Dara Navaei

LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
10:02 am

jpaguio  (deleted user)

9:55 am

Michael Garthwaite

Wednesday 10 Sep
9:57 am

Sean Nash

Monday 08 Sep
12:07 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2301: Added subsystem to enum names

Options
    • -16
    • +16
    ./valves.py
  2. … 13 more files in changeset.
11:03 am

Jonny Paguio <jpaguio@diality.com>

LDT-605: Updated TD valves.py function headers

Options
    • -2
    • +2
    ./valves.py
Sunday 07 Sep
4:31 pm

Dara Navaei

LEAHI-DIALIN-LDT-605_DD: D16, 28, 30, and 44 temperature overrides do not work
LEAHI-DIALIN-LDT-605_DD: D16, 28, 30, and 44 temperature overrides do not work
Thursday 04 Sep
9:18 am

Dara Navaei

9:18 am

Dara Navaei

Thursday 21 Aug
4:36 pm

jpaguio  (deleted user)