Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fixed.

fixed.

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

fixed for both _TO_PWM macros

fixed for both _TO_PWM macros

its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.

its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.

I don't see this macro being used anywhere.

I don't see this macro being used anywhere.

Updated

Updated

Added

Added

Updated

Updated

Fixed

Fixed

TRUE if low flow alarm is exempt, FALSE if not.

TRUE if low flow alarm is exempt, FALSE if not.

timeSinceP12Started?

timeSinceP12Started?

Should we have a comment for this one too?

Should we have a comment for this one too?

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

Updated to use isPersistentAlarmTriggered

Updated to use isPersistentAlarmTriggered

Fixed

Fixed

Updated

Updated

Updated

Updated

Changed the implementation

Changed the implementation

Fixed

Fixed

Why are we setting timer for pressure and PWM controls? Isn't it only applicable in flow control? And why aren't we resetting exempt flag in same place as timer?

Why are we setting timer for pressure and PWM controls? Isn't it only applicable in flow control?
And why aren't we resetting exempt flag in same place as timer?

I think this function should return TRUE if exempt (we are in first 10 seconds of flow control from off state). All criteria checked here in this function.

I think this function should return TRUE if exempt (we are in first 10 seconds of flow control from off state). All criteria checked here in this function.

I think timer should be internal (private) to this unit.

I think timer should be internal (private) to this unit.

We need to be calling the isPersistentAlarm function regardless of exemption, but only triggering the alarm if persistent alarm function returns TRUE and exemption is FALSE.

We need to be calling the isPersistentAlarm function regardless of exemption, but only triggering the alarm if persistent alarm function returns TRUE and exemption is FALSE.

I think timeout should be handled inside ROPump unit. From here, we should just call one function that tells us whether alarm should be exempt or not.

I think timeout should be handled inside ROPump unit. From here, we should just call one function that tells us whether alarm should be exempt or not.