td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 14
Total Committers: 15
Last Commit: 12 Mar
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
19 mins ago

Sean Nash

Remove blank line.

Remove blank line.

20 mins ago

Sean Nash

Move this transition function call to the transitionToPostTreatmentMode function below.

Move this transition function call to the transitionToPostTreatmentMode function below.

21 mins ago

Sean Nash

Invalid payload length shouldn't be a reject reason, it should cause a s/w fault (because it suggests the UI and TD software are not compatible versions).

Invalid payload length shouldn't be a reject reason, it should cause a s/w fault (because it suggests the UI and TD software are not compatible versions).

25 mins ago

Sean Nash

Still not what I had in mind. Let's discuss this.

Still not what I had in mind. Let's discuss this.

42 mins ago

Sean Nash

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

44 mins ago

Sean Nash

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

49 mins ago

Sean Nash

These are already in TxParams I believe.

These are already in TxParams I believe.

49 mins ago

Sean Nash

Should these be moved to Services\TxParams?

Should these be moved to Services\TxParams?

51 mins ago

Sean Nash

Change 1 to TRUE

Change 1 to TRUE

52 mins ago

Sean Nash

Agree with name change, but I think BOOL was the correct type. And BOOL is equivalent to U32 anyway so compiler won't care.

Agree with name change, but I think BOOL was the correct type. And BOOL is equivalent to U32 anyway so compiler won't care.

54 mins ago

Sean Nash

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

55 mins ago

Sean Nash

These should probably be moved to Services\TxParams.h because Messaging.c does not use them.

These should probably be moved to Services\TxParams.h because Messaging.c does not use them.

1 hr ago

Sean Nash

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

Thursday 23 Apr
11:11 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:10 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:10 am

Vendor - TEL - Varshini Nagabooshanam

updated

updated

11:10 am

Vendor - TEL - Varshini Nagabooshanam

added

added

11:10 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

11:09 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:09 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:59 am

Vendor - TEL - Jashwant Gantyada

10:55 am

Vendor - TEL - Arpita Srivastava

Wednesday 22 Apr
5:37 pm

Vinayakam Mani and Sean Nash

4:50 pm

Vendor - TEL - Sameer Poyil

2:05 pm

Sean Nash

Not necessary

Not necessary

2:05 pm

Sean Nash

This command should be given once on way out of prior state instead of every 50ms while in this state. We also need to zero the timer counter at same time so the timeout check below works.

This command should be given once on way out of prior state instead of every 50ms while in this state.
We also need to zero the timer counter at same time so the timeout check below works.

2:03 pm

Sean Nash

Response needs to be sent immediately (in message handler function). This is too late.

Response needs to be sent immediately (in message handler function). This is too late.

2:02 pm

Sean Nash

We shouldn't need to do this door check if you've required door be closed for the state. Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed ...

We shouldn't need to do this door check if you've required door be closed for the state.
Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed and call with ( FALSE ) on transition into a state that doesn't require door to be closed. When required = TRUE, the switch monitor will trigger the door open alarm for you.

1:57 pm

Sean Nash

Same organization comment that I had for post-tx mode. Let's keep functions related to each pre-tx state together separated by some kind of comment banner.

Same organization comment that I had for post-tx mode. Let's keep functions related to each pre-tx state together separated by some kind of comment banner.

1:56 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.