Pressures.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Keep 2 blank lines above the banner below.

Keep 2 blank lines above the banner below.

Is this still needed?

Is this still needed?

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

Keep 2 blank lines above the test support functions banner.

Keep 2 blank lines above the test support functions banner.

Not sure why you are making changes to this function. This function handles message from UI to pause or resume ultrafiltration. This is not a treatment parameter edit message, so I don't think it's...

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

No longer needed?

No longer needed?

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

These are already in TxParams I believe.

These are already in TxParams I believe.

Should these be moved to Services\TxParams?

Should these be moved to Services\TxParams?

Change 1 to TRUE

Change 1 to TRUE

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

LEAHI-TD-FIRMWARE-LDT-3970_Edit Treatment Parameters During Treatment - FW Implementation - 1/4:
LEAHI-TD-FIRMWARE-LDT-3970_Edit Treatment Parameters During Treatment - FW Implementation - 1/4:
Removed

Removed

Updated

Updated

Still not packed.

Still not packed.

Remove extra blank line.

Remove extra blank line.

Sure

Sure

Removed

Removed

I don't think we need to call setPressureLimitsToOuterBounds() either. The signal function will indirectly cause that function to be called later.

I don't think we need to call setPressureLimitsToOuterBounds() either. The signal function will indirectly cause that function to be called later.

Updated

Updated

I think we should just call signalInitiatePressureStabilization( USE_NORMAL_STABILIZATION_PERIOD );

I think we should just call signalInitiatePressureStabilization( USE_NORMAL_STABILIZATION_PERIOD );