dd-firmware / firmware / App / Modes

ModePreGenDialysate.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 2
Last Commit: 22 Apr
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 07 Jul
10:21 am

Vinayakam Mani

9:32 am

Michael Garthwaite

Thursday 03 Jul
1:21 pm

Sean Nash

12:45 pm

Vinayakam Mani

Done.

Done.

12:42 pm

Vinayakam Mani

Done.

Done.

12:41 pm

Vinayakam Mani

Removed.

Removed.

12:41 pm

Vinayakam Mani

Done.

Done.

12:41 pm

Vinayakam Mani

Done.

Done.

12:12 pm

Sean Nash

Mark these questions with TODO to aid in follow-up.

Mark these questions with TODO to aid in follow-up.

12:10 pm

Sean Nash

Reset to start state in default.

Reset to start state in default.

12:10 pm

Sean Nash

Is this complete state needed? I don't see how we even get here.

Is this complete state needed? I don't see how we even get here.

12:08 pm

Sean Nash

Add a TODO comment to complete when NV POST implemented.

Add a TODO comment to complete when NV POST implemented.

11:54 am

Sean Nash

Keep a blank line between banner and variables.

Keep a blank line between banner and variables.

Monday 23 Jun
5:48 pm

Dara Navaei

DD-LDT-815_Stop State DD
DD-LDT-815_Stop State DD
Wednesday 21 May
4:36 pm

Vinayakam Mani

2:05 pm

Michael Garthwaite and Sean Nash

Thursday 01 May
5:14 pm

Dara Navaei

DD-LDT-482_Treatment Parameters Create RX 1
DD-LDT-482_Treatment Parameters Create RX 1
Tuesday 22 Apr
2:42 pm

Vinayakam Mani

2:32 pm

Sean Nash and Michael Garthwaite

2:07 pm

Vinayakam Mani

Done.

Done.

2:07 pm

Vinayakam Mani

Done.

Done.

2:07 pm

Vinayakam Mani

Done.

Done.

2:06 pm

Vinayakam Mani

Done.

Done.

2:05 pm

Vinayakam Mani

LDT-319 code review comments

Options
    • -2
    • +2
    ./ModePreGenDialysate.h
  2. … 6 more files in changeset.
1:18 pm

Vinayakam Mani

Done

Done

1:16 pm

Sean Nash

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

1:14 pm

Sean Nash

stop should be capitalized.

stop should be capitalized.

1:14 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

I think these two conditions above the switch statement should end the state processing. So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE...

I think these two conditions above the switch statement should end the state processing.
So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE_DELIVERY_PAUSE ) && ( TRUE == areInletWaterConditionsAlarmsActive() ) ).
And then another else where the switch statement should go.
Hydraulic chamber and updating treatment settings should maybe be moved above all of this so they always happen.

11:43 am

Vinayakam Mani

Done.

Done.