dd-firmware / firmware / App / Controllers

PermeateTank.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 7
Last Commit: 15 Apr
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Apr
2:59 pm

Vinayakam Mani

2:57 pm

Vinayakam Mani

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

2:49 pm

Vinayakam Mani

lower? and change the D98 level sensor comment as well.

lower? and change the D98 level sensor comment as well.

2:47 pm

Vinayakam Mani

Remove empty line

Remove empty line

2:46 pm

Vinayakam Mani

Space before LVL_STATE_LOW

Space before LVL_STATE_LOW

2:44 pm

Vinayakam Mani

space inside array index.

space inside array index.

2:41 pm

Vinayakam Mani

Space inside parenthesis.

Space inside parenthesis.

2:40 pm

Vinayakam Mani

Change this to LEVEL_T enum.

Change this to LEVEL_T enum.

2:39 pm

Vinayakam Mani

Is this macro still being used? if not, delete it.

Is this macro still being used? if not, delete it.

7:47 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
Monday 20 Apr
9:51 am

Dara Navaei

9:23 am

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

6:52 am

Michael Garthwaite

fixed

fixed

Friday 17 Apr
6:02 pm

Sean Nash

5:17 pm

Vinayakam Mani

Align the comments.

Align the comments.

5:13 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Thursday 16 Apr
8:15 am

Michael Garthwaite

Wednesday 15 Apr
5:31 pm

Sean Nash and Vinayakam Mani

4:12 pm

Michael Garthwaite

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

3:37 pm

Vinayakam Mani

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

9:52 am

Michael Garthwaite

nope. removed.

nope. removed.

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

Tuesday 14 Apr
2:08 pm

Sean Nash

Add blank line before return.

Add blank line before return.

2:07 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

2:05 pm

Sean Nash

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

2:04 pm

Sean Nash

Lower case x

Lower case x

2:02 pm

Sean Nash

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?