leahi-dialin

build.sh

Clone Tools

Stats

Commits this week: 2
Total Committers: 3
Last Commit: 09:27
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
5 hrs ago

Zoltan Miskolci

- updated if to fix build

Options
    • -1
    • +1
    /build.sh
Tuesday 03 Feb
3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:54 pm

Behrouz NematiPour

This design is incorrect, For common codes, a proxy or a wrapper class should have been implemented. We will keep it for now to unblock the rest of the team.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

3:54 pm

Behrouz NematiPour

This is incorrect. We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use. We will keep it for now to unblock the rest of the...

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

2:27 pm

Zoltan Miskolci

When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

2:25 pm

Zoltan Miskolci

removed commented out line

removed commented out line

2:20 pm

Zoltan Miskolci

It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

2:20 pm

Zoltan Miskolci

Obviously not. You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

2:15 pm

Zoltan Miskolci

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override. Updating an alias's value when adding new entries to the enum i...

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

2:12 pm

Zoltan Miskolci

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

2:10 pm

Zoltan Miskolci

Yes

Yes

Monday 02 Feb
4:50 pm

Dara Navaei

Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else?

Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else?

4:43 pm

Dara Navaei

Treatment Params have been removed from firmware.

Treatment Params have been removed from firmware.

4:38 pm

Dara Navaei

Are these part of FPTemperatureSensorName class?

Are these part of FPTemperatureSensorName class?

4:32 pm

Behrouz NematiPour

same

same

4:32 pm

Behrouz NematiPour

same

same

4:32 pm

Dara Navaei

What is the use of this dictionary?

What is the use of this dictionary?

4:32 pm

Behrouz NematiPour

same here

same here

4:32 pm

Behrouz NematiPour

Same here.

Same here.

4:30 pm

Dara Navaei

Is this the only import that is needed?

Is this the only import that is needed?

4:30 pm

Behrouz NematiPour

I thought we removed this.

I thought we removed this.

4:29 pm

Behrouz NematiPour

what are these? and do we need them?

what are these?
and do we need them?

2:43 pm

Nicholas Ramirez

Friday 30 Jan
4:55 pm

Zoltan Miskolci

Removed

Removed

4:51 pm

Nicholas Ramirez

can you remove this Opode as MODE_TPAR is obsolete and update the rest of the enumeration

can you remove this Opode as MODE_TPAR is obsolete and update the rest of the enumeration

Thursday 29 Jan
5:08 pm

Zoltan Miskolci

- Updated dd_Defs to use static enums - Switched auto to integers for easier identification during debug - Changed name generation in build script to remove errors from python about name

Options
    • -5
    • +10
    /build.sh
  2. … 3 more files in changeset.
Tuesday 27 Jan
12:16 pm

Dara Navaei

LEAHI-DIALIN-LDT-3350_[Leahi-Dialin] Add from_str function to the enums
LEAHI-DIALIN-LDT-3350_[Leahi-Dialin] Add from_str function to the enums