leahi-common

Clone Tools

Stats

Commits this week: 12
Total Committers: 19
Last Commit: 14 Apr
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
36 mins ago

Vendor - TEL - Arpita Srivastava and Sean Nash

1 hr ago

Sean Nash

Rename similar to ADDR definitions below. these are not commands.

Rename similar to ADDR definitions below. these are not commands.

1 hr ago

Sean Nash

Combine charger and pack data into one payload with one broadcast message.

Combine charger and pack data into one payload with one broadcast message.

1 hr ago

Sean Nash

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.

1 hr ago

Sean Nash

I think we only need one data message for both charger and battery pack data.

I think we only need one data message for both charger and battery pack data.

1 hr ago

Sean Nash

Remove.

Remove.

1 hr ago

Sean Nash

uncomment.

uncomment.

Monday 18 May
9:45 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

9:44 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Sunday 17 May
11:46 pm

Sean Nash

Why was this function header changed? I think it was correct before.

Why was this function header changed? I think it was correct before.

11:37 pm

Sean Nash

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:23 pm

Sean Nash

Now it's backward. You have to change the ENABLE to DISABLE too.

Now it's backward. You have to change the ENABLE to DISABLE too.

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

11:14 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

Friday 15 May
6:12 pm

Sean Nash

Call the init for the battery driver here.

Call the init for the battery driver here.

6:11 pm

Sean Nash

INVALID_BATTERY

INVALID_BATTERY

5:52 pm

Sean Nash

Remove repeating entries.

Remove repeating entries.

5:49 pm

Sean Nash

remove extra blank line.

remove extra blank line.

5:48 pm

Sean Nash

Remove this comment.

Remove this comment.

5:48 pm

Sean Nash

Remove blank line.

Remove blank line.

5:47 pm

Sean Nash

initialize all of these in init function.

initialize all of these in init function.

5:47 pm

Sean Nash

Missing doxygen group

Missing doxygen group

5:46 pm

Sean Nash

These should be in alphabetical order.

These should be in alphabetical order.

5:45 pm

Sean Nash

Update all function headers to Leahi format (e.g. input and output have a \b to make them bold).

Update all function headers to Leahi format (e.g. input and output have a \b to make them bold).