dd-firmware / firmware / App / Modes

ModeService.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 02 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 25 Feb
3:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
Friday 15 Nov 2024
1:04 pm

Vinayakam Mani

11:27 am

Dara Navaei and Sean Nash

Thursday 14 Nov 2024
3:39 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:37 pm

Vinayakam Mani

Done.

Done.

3:36 pm

Vinayakam Mani

Done.

Done.

3:36 pm

Vinayakam Mani

Done.

Done.

3:36 pm

Vinayakam Mani

Done.

Done.

9:20 am

Sean Nash

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

9:18 am

Sean Nash

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases. And I don't think we should be setting result to TRUE here necessarily. If we...

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases.
And I don't think we should be setting result to TRUE here necessarily. If we set result to FALSE above, it should stay FALSE.

9:12 am

Sean Nash

ModeGenDialysate should move up before ModeInitPOST to be in alphabetical order.

ModeGenDialysate should move up before ModeInitPOST to be in alphabetical order.

9:11 am

Sean Nash

Indent function name more to align like others.

Indent function name more to align like others.

9:08 am

Sean Nash

Fix "Dialysatey" (remove y). And I think "Gend" should be GenD" in all of these function names.

Fix "Dialysatey" (remove y). And I think "Gend" should be GenD" in all of these function names.

9:07 am

Sean Nash

Who is calling this function? If this function is not doing anything other than changing modes, do we really need this function? Caller can just call requestNewOperationMode().

Who is calling this function? If this function is not doing anything other than changing modes, do we really need this function? Caller can just call requestNewOperationMode().

9:01 am

Sean Nash

If no inputs or outpus, say "none".

If no inputs or outpus, say "none".

9:01 am

Sean Nash

If no alarms triggered, don't include an Alarm details line in the header.

If no alarms triggered, don't include an Alarm details line in the header.

9:00 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:55 am

Sean Nash

"Valve" should be plural in these function names. Change "the all" to "all".

"Valve" should be plural in these function names. Change "the all" to "all".

Wednesday 13 Nov 2024
5:48 pm

Vinayakam Mani

Done.

Done.

5:48 pm

Vinayakam Mani

Done.

Done.

5:48 pm

Vinayakam Mani

Done.

Done.

5:47 pm

Vinayakam Mani

Removed balancing chamber pause state.

Removed balancing chamber pause state.

11:02 am

Sean Nash

Seems like this would be a separate state or maybe we go to pause state too.

Seems like this would be a separate state or maybe we go to pause state too.

9:13 am

Sean Nash

Should this be "if ( DD_MODE_GEND == ddMode )" ? I don't think this message makes sense in any other mode.

Should this be "if ( DD_MODE_GEND == ddMode )" ? I don't think this message makes sense in any other mode.

9:02 am

Sean Nash

This message handler would be more appropriately placed in TDInterface unit.

This message handler would be more appropriately placed in TDInterface unit.