td-firmware

firmware

Clone Tools

Stats

Commits this week: 30
Total Committers: 17
Last Commit: 17 Feb
Commits this week: 30

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
52 mins ago

Sean Nash

You only addressed the first part of my comment above.

You only addressed the first part of my comment above.

54 mins ago

Sean Nash

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

5 hrs ago

Vendor - TEL - Arpita Srivastava

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input. Then you will not need all thes...

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input.
Then you will not need all these repetitive functions:
isSystolicBpLowAlarmLimitValid
isSystolicBpHighAlarmLimitValid
isHeartRateLowAlarmLimitValid
isHeartRateHighAlarmLimitValid

Similarly, you can create another function with input as TREATMENT_PARAM_T minValue and TREATMENT_PARAM_T maxValue for isVitalsMeasurementIntervalValid()

5 hrs ago

Vendor - TEL - Arpita Srivastava

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

5 hrs ago

Vendor - TEL - Arpita Srivastava

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested Remove from output: recircMediumAlarmGiven and recircResumeRequested

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested
Remove from output: recircMediumAlarmGiven and recircResumeRequested

5 hrs ago

Vendor - TEL - Arpita Srivastava

Output should be none.

Output should be none.

5 hrs ago

Vendor - TEL - Arpita Srivastava

Just curious, at what condition we leave this state? It looks like, once we enter this state, we stay.

Just curious, at what condition we leave this state?
It looks like, once we enter this state, we stay.

Monday 08 Jun
3:32 pm

Sean Nash

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

3:27 pm

Sean Nash

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

3:08 pm

Sean Nash

These should be moved down to an "else" in the if statement below (payload length check).

These should be moved down to an "else" in the if statement below (payload length check).

3:04 pm

Sean Nash

It doesn't look like these memsets are necessary. Consider removing them.

It doesn't look like these memsets are necessary. Consider removing them.

3:03 pm

Sean Nash

Remove blank line.

Remove blank line.

3:02 pm

Sean Nash

Can you move this down with the other vitals functions?

Can you move this down with the other vitals functions?

2:33 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4149_Pinch Valves - FW Implementation - 1/1:
LEAHI-TD-FIRMWARE-LDT-4149_Pinch Valves - FW Implementation - 1/1:
11:20 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
Friday 05 Jun
4:14 pm

Sean Nash

Just use 0x0 and 0xFFFFFFFF

Just use 0x0 and 0xFFFFFFFF

4:13 pm

Sean Nash

NUM_OF_BATTERY_REGISTERS - 1

NUM_OF_BATTERY_REGISTERS - 1

4:13 pm

Sean Nash

Put 2 items at end of the list here: BATTERY_END_OF_LIST_TIME_TO_PUBLISH NUM_OF_BATTERY_REGISTERS

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

4:10 pm

Sean Nash

Put this one back to NUM_OF_BATTERY_DEVICES.

Put this one back to NUM_OF_BATTERY_DEVICES.

4:08 pm

Sean Nash

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

4:04 pm

Sean Nash

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

1:36 pm

Sean Nash

1:23 pm

Vendor - TEL - Arpita Srivastava

Please add Alarm ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Please add Alarm
ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

1:19 pm

Vendor - TEL - Arpita Srivastava

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

1:16 pm

Vendor - TEL - Arpita Srivastava

Please add currentPreTreatmentState to inputs.

Please add currentPreTreatmentState to inputs.

1:07 pm

Vendor - TEL - Arpita Srivastava

currentPreTxRecircState looks like an input.

currentPreTxRecircState looks like an input.

10:08 am

Sean Nash

9:46 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4505_(TD) H4 blood pump does not run in reverse
LEAHI-TD-FIRMWARE-LDT-4505_(TD) H4 blood pump does not run in reverse
9:32 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6:
LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6:
Thursday 04 Jun
1:44 pm

Sean Nash

Put recirc state after Rx state (both here in switch statement and also in enumeration).

Put recirc state after Rx state (both here in switch statement and also in enumeration).