firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
You only addressed the first part of my comment above.

You only addressed the first part of my comment above.

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input. Then you will not need all thes...

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input.
Then you will not need all these repetitive functions:
isSystolicBpLowAlarmLimitValid
isSystolicBpHighAlarmLimitValid
isHeartRateLowAlarmLimitValid
isHeartRateHighAlarmLimitValid

Similarly, you can create another function with input as TREATMENT_PARAM_T minValue and TREATMENT_PARAM_T maxValue for isVitalsMeasurementIntervalValid()

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested Remove from output: recircMediumAlarmGiven and recircResumeRequested

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested
Remove from output: recircMediumAlarmGiven and recircResumeRequested

Output should be none.

Output should be none.

Just curious, at what condition we leave this state? It looks like, once we enter this state, we stay.

Just curious, at what condition we leave this state?
It looks like, once we enter this state, we stay.

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

These should be moved down to an "else" in the if statement below (payload length check).

These should be moved down to an "else" in the if statement below (payload length check).

It doesn't look like these memsets are necessary. Consider removing them.

It doesn't look like these memsets are necessary. Consider removing them.

Remove blank line.

Remove blank line.

Can you move this down with the other vitals functions?

Can you move this down with the other vitals functions?

LEAHI-TD-FIRMWARE-LDT-4149_Pinch Valves - FW Implementation - 1/1:
LEAHI-TD-FIRMWARE-LDT-4149_Pinch Valves - FW Implementation - 1/1:
LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
Just use 0x0 and 0xFFFFFFFF

Just use 0x0 and 0xFFFFFFFF

NUM_OF_BATTERY_REGISTERS - 1

NUM_OF_BATTERY_REGISTERS - 1

Put 2 items at end of the list here: BATTERY_END_OF_LIST_TIME_TO_PUBLISH NUM_OF_BATTERY_REGISTERS

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

Put this one back to NUM_OF_BATTERY_DEVICES.

Put this one back to NUM_OF_BATTERY_DEVICES.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

Please add Alarm ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Please add Alarm
ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Please add currentPreTreatmentState to inputs.

Please add currentPreTreatmentState to inputs.

currentPreTxRecircState looks like an input.

currentPreTxRecircState looks like an input.

LEAHI-TD-FIRMWARE-LDT-4505_(TD) H4 blood pump does not run in reverse
LEAHI-TD-FIRMWARE-LDT-4505_(TD) H4 blood pump does not run in reverse
LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6:
LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6:
Put recirc state after Rx state (both here in switch statement and also in enumeration).

Put recirc state after Rx state (both here in switch statement and also in enumeration).