Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
done updated below in the function as well.

done updated below in the function as well.

done.

done.

LDT-1394 addressed code review comments

  1. … 1 more file in changeset.
Intentional?

Intentional?

update the header and field comments in later commits

update the header and field comments in later commits

LDT-1394 fixed the equation based on Nick's updated co-eff's

  1. … 1 more file in changeset.
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
You are calling setAirPumpState in if and else. Consider just calling once after the if/else.

You are calling setAirPumpState in if and else. Consider just calling once after the if/else.

Add space between if and (

Add space between if and (

Fixed

Fixed

LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

Comment to right no longer makes sense.

Comment to right no longer makes sense.

Should this event be TD_EVENT_AIR_TRAP_FILL?

Should this event be TD_EVENT_AIR_TRAP_FILL?

blank line before return.

blank line before return.

Blank line after declarations.

Blank line after declarations.

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Added

Added

Updated

Updated

Add a blank line after declarations.

Add a blank line after declarations.