Activity dd-firmware/firmware

7:31 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3597-1
started review

LEAHI-DD-FIRMWARE-LDT-3597_(DD) D5 Heater not turning on on B2.0 HW

4:56 pm

Sean Nash

Since this driver is temporary, I don't think we need to document the approaches.

4:53 pm

Sean Nash

Doesn't look like this switch statement is doing anything. Can we remove it?

4:50 pm

Sean Nash

The Teensy driver is temporary - we will be deleting this driver in a few months. Let's just look for problems that might affect proper functionality.

4:00 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3219-3
finished reviewing

3:27 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3219-3
joined review

2:44 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3219-3
started review

LDT-3219 removing D3 open in standby mode

2:13 pm

Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3514-1
finished reviewing

1:52 pm

Raghu Kallala

More
LEAHI-DD-FIRMWARE-LDT-3514-1
finished reviewing

1:03 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3514-1
started review

LEAHI-DD-FIRMWARE-LDT-3514_Dialin config request to disable IOFP current monitoring

11:40 am

Michael Garthwaite

then we return false as expected

11:33 am

Michael Garthwaite

These are correct variable names based on their coefficient names in calculations of conductivity.

11:31 am

Michael Garthwaite

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

11:30 am

Michael Garthwaite

removed. thanks!

11:30 am

Michael Garthwaite

parameter check happens in getTeensyCondId

11:25 am

Michael Garthwaite

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

11:24 am

Michael Garthwaite

Not for this situation since its an array of structs and looks like a 2d array. Please see static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c static const DD_OP_MODE_T MODE_TRAN...

Not for this situation since its an array of structs and looks like a 2d array. Please see

static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c
static const DD_OP_MODE_T MODE_TRANSITION_TABLE in OperationModes.c
static PI_CONTROLLER_T piControllers in PIControllers.c ( FWCommon repo )

8:13 am