leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use #define for array size.

Use #define for array size.

Make the 6 a #define

Make the 6 a #define

only 1 return statement

only 1 return statement

remove comma

remove comma

return FALSE on else

return FALSE on else

signal functions should return BOOL.

signal functions should return BOOL.

Move up with rest

Move up with rest

Move this function to your service.

Move this function to your service.

Add HDF state too

Add HDF state too

Not needed.

Not needed.

Should always exec your bolus sm.

Should always exec your bolus sm.

Keep 2 blank lines before banner

Keep 2 blank lines before banner

Add fluid bolus state

Add fluid bolus state

Add fluid bolus state

Add fluid bolus state

FLUID_BOLUS_CMD_EVENT

FLUID_BOLUS_CMD_EVENT

slaveAddr should be an enum now and so just "device".

slaveAddr should be an enum now and so just "device".

Add a banner before Dialin test support functions (see other units for example).

Add a banner before Dialin test support functions (see other units for example).

Initialize .override to OVERRIDE_RESET

Initialize .override to OVERRIDE_RESET

Why is this commented out? Do we not need to initialize it?

Why is this commented out? Do we not need to initialize it?

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

Remove this blank line.

Remove this blank line.

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

This merge conflict is still unresolved.

This merge conflict is still unresolved.

leak in the comment section.

leak in the comment section.

Where is alarm 191..203?

Where is alarm 191..203?

Align comment.

Align comment.

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

Should this line be un-commented?

Should this line be un-commented?