td-firmware / firmware / App / Monitors

Pressures.h

Clone Tools

Stats

Commits this week: 3
Total Committers: 4
Last Commit: 28 Apr
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Apr
3:57 pm

Sean Nash

I don't think you want stored (old) value here. You want value from first message before confirmation.

I don't think you want stored (old) value here. You want value from first message before confirmation.

Wednesday 29 Apr
9:57 am

Sean Nash

Keep 2 blank lines above the banner below.

Keep 2 blank lines above the banner below.

9:56 am

Sean Nash

Is this still needed?

Is this still needed?

9:56 am

Sean Nash

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

9:49 am

Sean Nash

Keep 2 blank lines above the test support functions banner.

Keep 2 blank lines above the test support functions banner.

9:47 am

Sean Nash

Not sure why you are making changes to this function. This function handles message from UI to pause or resume ultrafiltration. This is not a treatment parameter edit message, so I don't think it's...

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

9:43 am

Sean Nash

No longer needed?

No longer needed?

9:42 am

Sean Nash

9:42 am

Sean Nash

Tuesday 28 Apr
9:13 pm

Vendor - TEL - Vijay Pamula

LDT-3970: remove extra whitespace and blank lines

Options
    • -1
    • +0
    ./Pressures.h
  2. … 1 more file in changeset.
8:33 pm

Vendor - TEL - Vijay Pamula

LDT-3970: Adressed code review comments

Options
    • -1
    • +1
    ./Pressures.h
  2. … 8 more files in changeset.
Sunday 26 Apr
1:08 pm

Sean Nash

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

1:06 pm

Sean Nash

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

1:02 pm

Sean Nash

These are already in TxParams I believe.

These are already in TxParams I believe.

1:01 pm

Sean Nash

Should these be moved to Services\TxParams?

Should these be moved to Services\TxParams?

12:59 pm

Sean Nash

Change 1 to TRUE

Change 1 to TRUE

12:56 pm

Sean Nash

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

12:48 pm

Sean Nash

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

Friday 24 Apr
8:42 pm

Vendor - TEL - Vijay Pamula

LDT-3970: Implemented edit treatment parameters

Options
    • -0
    • +1
    ./Pressures.h
  2. … 6 more files in changeset.
Thursday 16 Apr
7:32 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3970_Edit Treatment Parameters During Treatment - FW Implementation - 1/4:
LEAHI-TD-FIRMWARE-LDT-3970_Edit Treatment Parameters During Treatment - FW Implementation - 1/4:
Friday 13 Mar
3:23 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Pressures.h
  2. … 1 more file in changeset.
3:04 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' into LDT-1840-Transmembrane-Pressure-update

Options
    • -1
    • +3
    ./Pressures.h
  2. … 1 more file in changeset.
2:59 pm

Vendor - TEL - Varshini Nagabooshanam

2:58 pm

Zoltan Miskolci and Sean Nash

2:39 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

2:39 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:38 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-1840-Transmembrane-Pressure-update

Options
    • -0
    • +2
    ./Pressures.h
  2. … 1 more file in changeset.
2:26 pm

Sean Nash

Still not packed.

Still not packed.

2:25 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:19 pm

Vendor - TEL - Varshini Nagabooshanam

Sure

Sure