firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

comment still needed?

comment still needed?

LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
Keep 2 blank lines above the banner below.

Keep 2 blank lines above the banner below.

Is this still needed?

Is this still needed?

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

Keep 2 blank lines above the test support functions banner.

Keep 2 blank lines above the test support functions banner.

Not sure why you are making changes to this function. This function handles message from UI to pause or resume ultrafiltration. This is not a treatment parameter edit message, so I don't think it's...

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

No longer needed?

No longer needed?

???

???

Do we need a parameter for confirmation?

Do we need a parameter for confirmation?

It looks like you deleted it instead of fixing it.

It looks like you deleted it instead of fixing it.

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

Need to check heparin bolus volume > 0 too.

Need to check heparin bolus volume > 0 too.

Don't we need to check this too still?

Don't we need to check this too still?

Do we need to reset authStartTime here before we go to next state?

Do we need to reset authStartTime here before we go to next state?

Put positive case first ( TRUE == ...), then alarm and reject cases.

Put positive case first ( TRUE == ...), then alarm and reject cases.

No occlusion sensor in Leahi. Delete variable and references to it.

No occlusion sensor in Leahi. Delete variable and references to it.

We should now send the scanned text to the UI s/w for authentication before we go to next state where we wait for UI response.

We should now send the scanned text to the UI s/w for authentication before we go to next state where we wait for UI response.

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

The barcode reader is under TD f/w control via the FPGA (not implemented yet). So asking UI s/w to do a scan doesn't make sense.

The barcode reader is under TD f/w control via the FPGA (not implemented yet). So asking UI s/w to do a scan doesn't make sense.

What is this flag for? And why is it only set here and not above where test passed. Also, we are going to the loaded check state, but we are not requesting a scan first.

What is this flag for? And why is it only set here and not above where test passed.
Also, we are going to the loaded check state, but we are not requesting a scan first.

Local declarations should come first - move up above reset function above.

Local declarations should come first - move up above reset function above.