Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3272 addressed the code review comments

  1. … 3 more files in changeset.
This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

Done

Done

Done

Done

Done

Done

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

Remove extra copyright block.

Remove extra copyright block.

These 2 new channels should be using message boxes before Dialin channel message boxes. Align with buffers enum.

These 2 new channels should be using message boxes before Dialin channel message boxes. Align with buffers enum.

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

Same.

Same.

Same

Same

We shouldn't delete generated code. Add a #if 0 in this user code section and add a #endif in the user section below the coreEnableFlashEcc() call.

We shouldn't delete generated code. Add a #if 0 in this user code section and add a #endif in the user section below the coreEnableFlashEcc() call.

LDT-3273 renamed the CAN mailboxes of DD, disabled RAM ECC check

  1. … 3 more files in changeset.
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LDT-3272 added DD to UI and UI to DD CAN channels

  1. … 3 more files in changeset.
LDT-3259 updated HALCoGen. Merged staging and resolved the conflicts

  1. … 4 more files in changeset.
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

I think using filtered values for alarms makes sense.

I think using filtered values for alarms makes sense.

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want...

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want a sample point.

in Denali, looks like the HD got the filtered temperature value from the DG for checking dialysate temp alarms. Are we upholding that same design of using a filtered value for leahi dialysate temp?

I don't see fix. Did you push fwcommon?

I don't see fix. Did you push fwcommon?

Restore this blank line.

Restore this blank line.

Remove all of these blank lines please.

Remove all of these blank lines please.